Skip to content

Commit 54ddeba

Browse files
committed
Clean up some TODO comments that have been addressed
1 parent 7a1475d commit 54ddeba

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

ci/svd2rust-regress/src/main.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,6 @@ fn main() {
142142
);
143143
}
144144
Err(e) => {
145-
// TODO: I think this is the right ordering. I don't think we
146-
// care about any reads until we are done with the parallel part,
147-
// though performance probably doesn't matter because each iter
148-
// takes ~minutes
149145
any_fails.store(true, Ordering::Release);
150146
eprintln!(
151147
"Failed: {} - {} seconds - {:?}",

ci/svd2rust-regress/src/svd_test.rs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,9 @@ use reqwest;
77
use std::path::PathBuf;
88

99
static CRATES_ALL: &[&str] = &["bare-metal = \"0.1.0\"", "vcell = \"0.1.0\""];
10-
1110
static CRATES_MSP430: &[&str] = &["msp430 = \"0.1.0\""];
12-
1311
static CRATES_CORTEX_M: &[&str] = &["cortex-m = \"0.4.0\"", "cortex-m-rt = \"0.3.0\""];
14-
1512
static CRATES_RISCV: &[&str] = &["riscv = \"0.1.4\"", "riscv-rt = \"0.1.3\""];
16-
1713
static PROFILE_ALL: &[&str] = &["[profile.dev]", "incremental = false"];
1814

1915
fn path_helper(input: &[&str]) -> PathBuf {
@@ -84,8 +80,6 @@ pub fn test(t: &TestCase, bin_path: &PathBuf) -> Result<()> {
8480

8581
// Create a new cargo project. It is necesary to set the user, otherwise
8682
// cargo init will not work (when running in a container with no user set)
87-
// TODO: Will fail if directory already exists
88-
8983
Command::new("cargo")
9084
.env("USER", user)
9185
.arg("init")
@@ -99,7 +93,6 @@ pub fn test(t: &TestCase, bin_path: &PathBuf) -> Result<()> {
9993
.capture_outputs(true, "cargo init", None, None)?;
10094

10195
// Add some crates to the Cargo.toml of our new project
102-
// TODO: Only add the right crates for this arch to make the compilation faster
10396
let svd_toml = path_helper_base(&chip_dir, &["Cargo.toml"]);
10497
let mut file = OpenOptions::new()
10598
.write(true)

0 commit comments

Comments
 (0)