Skip to content

Commit 7952349

Browse files
committed
review suggestion
1 parent 4672179 commit 7952349

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

src/generate/register.rs

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1498,30 +1498,24 @@ fn add_from_variants_with_default(
14981498
desc: &str,
14991499
reset_value: Option<u64>,
15001500
) {
1501-
let repr = if fty == "bool" {
1502-
quote!()
1503-
} else {
1504-
quote! { #[repr(#fty)] }
1505-
};
1506-
15071501
let mut vars = TokenStream::new();
1508-
let mut casts = TokenStream::new();
1502+
let mut arms = TokenStream::new();
15091503
for (v, c) in variants.iter().chain(std::iter::once(default)).map(|v| {
15101504
let desc = util::escape_special_chars(&util::respace(&format!("{}: {}", v.value, v.doc)));
15111505
let pcv = &v.pc;
15121506
let pcval = &util::unsuffixed(v.value);
15131507
(
15141508
quote! {
15151509
#[doc = #desc]
1516-
#pcv,
1510+
#pcv = #pcval,
15171511
},
15181512
quote! {
15191513
#pc::#pcv => #pcval,
15201514
},
15211515
)
15221516
}) {
15231517
vars.extend(v);
1524-
casts.extend(c);
1518+
arms.extend(c);
15251519
}
15261520

15271521
let desc = if let Some(rv) = reset_value {
@@ -1533,15 +1527,14 @@ fn add_from_variants_with_default(
15331527
mod_items.extend(quote! {
15341528
#[doc = #desc]
15351529
#[derive(Clone, Copy, Debug, PartialEq)]
1536-
#repr
15371530
pub enum #pc {
15381531
#vars
15391532
}
15401533
impl From<#pc> for #fty {
15411534
#[inline(always)]
15421535
fn from(variant: #pc) -> Self {
15431536
match variant {
1544-
#casts
1537+
#arms
15451538
}
15461539
}
15471540
}

0 commit comments

Comments
 (0)