Merge #570

570: don't cast if not use_mask r=adamgreig a=burrbull

#537 

Co-authored-by: Andrey Zgarbul <[email protected]>

Author: bors[bot]

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Fixed
 
+- Don't cast if field same type as register
 - Parenthesizing `#offset_calc` to avoid clippy's warning of operator precedence
 - Replace suffix in fields' name before converting to snake case when generating methods #563
 

src/generate/register.rs

@@ -408,7 +408,7 @@ pub fn fields(
                 }
             } else {
                 quote! {
-                    self.bits #cast
+                    self.bits
                 }
             };
 
@@ -436,7 +436,7 @@ pub fn fields(
                         }
                     } else {
                         quote! {
-                            self.bits #cast
+                            self.bits
                         }
                     };
                     let name_sc_n = Ident::new(
@@ -720,7 +720,7 @@ pub fn fields(
                     let op = if use_mask {
                         quote!{ self.w.bits = (self.w.bits & !#hexmask) | (value as #rty & #hexmask); }
                     } else {
-                        quote!{ self.w.bits = value as #rty; }
+                        quote!{ self.w.bits = value; }
                     };
 
                     quote! {