Merge pull request #107 from stm32-rs/fixreadaction

burrbull · web-flow · commit 56c98ffcca84 · 2022-05-01T08:19:51.000+03:00
fix read action modify
diff --git a/src/patch/register.rs b/src/patch/register.rs
@@ -533,11 +533,7 @@ impl RegisterExt for Register {
 
     fn set_field_read_action(&mut self, fspec: &str, action: ReadAction) {
         for ftag in self.iter_fields(fspec) {
-            ftag.read_action = if action == ReadAction::Modify {
-                None
-            } else {
-                Some(action)
-            };
+            ftag.read_action = Some(action);
         }
     }
 
diff --git a/svdtools/patch.py b/svdtools/patch.py
@@ -1387,9 +1387,6 @@ def set_field_read_action(self, fspec, action):
             tag = ftag.find("readAction")
             if tag is None:
                 tag = ET.SubElement(ftag, "readAction")
-            elif action == "modify":
-                ftag.remove(tag)
-                return
             tag.text = action
 
     def set_field_modified_write_values(self, fspec, mwv):

Original file line number	Diff line number	Diff line change
`@@ -533,11 +533,7 @@ impl RegisterExt for Register {`
`533`	`533`
`534`	`534`	`fn set_field_read_action(&mut self, fspec: &str, action: ReadAction) {`
`535`	`535`	`for ftag in self.iter_fields(fspec) {`
`536`		`- ftag.read_action = if action == ReadAction::Modify {`
`537`		`- None`
`538`		`- } else {`
`539`		`- Some(action)`
`540`		`- };`
	`536`	`+ ftag.read_action = Some(action);`
`541`	`537`	`}`
`542`	`538`	`}`
`543`	`539`