clippy

Author: burrbull

src/patch/device.rs

@@ -410,9 +410,9 @@ impl DeviceExt for Device {
             .enumerate()
             .find(|(_, f)| f.name == pnew)
             .ok_or_else(|| anyhow!("peripheral {pnew} not found"))?;
-        d.name = new.name.clone();
+        d.name.clone_from(&new.name);
         d.base_address = new.base_address;
-        d.interrupt = new.interrupt.clone();
+        d.interrupt.clone_from(&new.interrupt);
         *new = d;
         for (i, p) in self.peripherals.iter_mut().enumerate() {
             if p.derived_from.as_deref() == Some(pold) {

src/patch/peripheral.rs

@@ -132,6 +132,7 @@ pub(crate) trait RegisterBlockExt: Name {
     fn get_mut_reg(&mut self, name: &str) -> Option<&mut Register>;
 
     /// Register/cluster block
+    #[allow(unused)]
     fn children(&self) -> Option<&Vec<RegisterCluster>>;
 
     /// Register/cluster block
@@ -402,6 +403,7 @@ pub(crate) trait RegisterBlockExt: Name {
         }
     }
     /// Work through a register, handling all fields
+    #[allow(unused)]
     fn process_register(
         &mut self,
         rspec: &str,

src/patch/register.rs

@@ -389,7 +389,7 @@ impl RegisterExt for Register {
             for f in fields.iter_mut() {
                 if names.contains(&f.name) {
                     if first {
-                        desc = f.description.clone();
+                        desc.clone_from(&f.description);
                         first = false;
                     }
                     bitwidth += f.bit_range.width;