Add tests

Author: smoelius

cargo-afl/src/config.rs

@@ -347,3 +347,153 @@ fn check_llvm_and_get_config() -> Result<String> {
 
     Ok(llvm_config)
 }
+
+#[cfg(test)]
+mod tests {
+    use super::{copy_aflplusplus_submodule, remove_aflplusplus_dir, update_to_stable_or_tag};
+    use crate::{common, config::is_repo};
+    use anyhow::Result;
+    use assert_cmd::cargo::CommandCargoExt;
+    use std::{path::Path, process::Command};
+    use tempfile::tempdir;
+
+    #[derive(Clone, Copy, Debug)]
+    enum State {
+        Nonexistent,
+        Submodule,
+        Tag(&'static str),
+        Stable,
+    }
+
+    const TESTCASES: &[(State, State, &[&str])] = &[
+        // smoelius: There is currently no way to update to the submodule.
+        // (State::Nonexistent, State::Submodule, &[]),
+        (
+            State::Nonexistent,
+            State::Tag("v4.33c"),
+            &[
+                if cfg!(target_os = "macos") {
+                    "Previous HEAD position was"
+                } else {
+                    "Note: switching to 'v4.33c'."
+                },
+                "HEAD is now at",
+            ],
+        ),
+        (
+            State::Nonexistent,
+            State::Stable,
+            &[
+                if cfg!(target_os = "macos") {
+                    "Previous HEAD position was"
+                } else {
+                    "Note: switching to 'origin/stable'."
+                },
+                "HEAD is now at",
+            ],
+        ),
+        (
+            State::Submodule,
+            State::Tag("v4.33c"),
+            &[
+                if cfg!(target_os = "macos") {
+                    "Previous HEAD position was"
+                } else {
+                    "Note: switching to 'v4.33c'."
+                },
+                "HEAD is now at",
+            ],
+        ),
+        (
+            State::Submodule,
+            State::Stable,
+            &[
+                if cfg!(target_os = "macos") {
+                    "Previous HEAD position was"
+                } else {
+                    "Note: switching to 'origin/stable'."
+                },
+                "HEAD is now at",
+            ],
+        ),
+        // smoelius: It should be possible to go from a tag to the stable version.
+        (
+            State::Tag("v4.33c"),
+            State::Stable,
+            &["Previous HEAD position was", "HEAD is now at"],
+        ),
+        // smoelius: It should be possible to go from the stable version to a tag.
+        (
+            State::Stable,
+            State::Tag("v4.33c"),
+            &["Previous HEAD position was", "HEAD is now at"],
+        ),
+    ];
+
+    #[test]
+    fn update() {
+        let mut base_dir = common::xdg_base_dir();
+
+        for &(before, after, line_prefixes) in TESTCASES {
+            eprintln!("{before:?} -> {after:?}");
+
+            let tempdir = tempdir().unwrap();
+
+            // smoelius: Based on https://github.com/whitequark/rust-xdg/issues/44, the recommended
+            // way of testing with a fake value of `XDG_DATA_HOME` seems to be manually overwriting
+            // the `data_home` field in `xdg::BaseDirectories`.
+            base_dir.data_home = Some(tempdir.path().to_path_buf());
+
+            let aflplusplus_dir = common::aflplusplus_dir_from_base_dir(&base_dir).unwrap();
+
+            assert!(aflplusplus_dir.starts_with(tempdir.path()));
+
+            set_aflplusplus_dir_contents(before, &aflplusplus_dir).unwrap();
+
+            let mut command = Command::cargo_bin("cargo-afl").unwrap();
+            command.args(["afl", "config", "--update"]);
+            command.env("XDG_DATA_HOME", tempdir.path());
+            match after {
+                State::Nonexistent | State::Submodule => unreachable!(),
+                State::Tag(tag) => {
+                    command.args(["--tag", tag]);
+                }
+                State::Stable => {}
+            }
+            let output = command.output().unwrap();
+            assert!(output.status.success());
+            let stderr = String::from_utf8(output.stderr).unwrap();
+            contains_expected_line_prefixes(&stderr, line_prefixes);
+        }
+    }
+
+    fn set_aflplusplus_dir_contents(state: State, aflplusplus_dir: &Path) -> Result<()> {
+        let result = match state {
+            State::Nonexistent => remove_aflplusplus_dir(aflplusplus_dir),
+            State::Submodule => copy_aflplusplus_submodule(aflplusplus_dir),
+            State::Tag(tag) => update_to_stable_or_tag(aflplusplus_dir, Some(tag)),
+            State::Stable => update_to_stable_or_tag(aflplusplus_dir, None),
+        };
+        // smoelius: Sanity.
+        assert!(
+            is_repo(aflplusplus_dir)
+                .is_ok_and(|value| value == matches!(state, State::Tag(_) | State::Stable))
+        );
+        result
+    }
+
+    fn contains_expected_line_prefixes(stderr: &str, mut line_prefixes: &[&str]) {
+        for line in stderr.lines() {
+            if line_prefixes
+                .first()
+                .is_some_and(|prefix| line.starts_with(prefix))
+            {
+                line_prefixes = &line_prefixes[1..];
+            }
+        }
+        assert!(
+            line_prefixes.is_empty(),
+            "Could not find line prefix {line_prefixes:?}:\n```\n{stderr}```"
+        );
+    }
+}

cargo-afl/src/main.rs

@@ -535,6 +535,16 @@ mod tests {
         }
     }
 
+    #[test]
+    fn tag_requires_update() {
+        let output = cargo_afl(&["config", "--tag", "v4.33c"]).output().unwrap();
+        assert_failure(&output, None);
+        assert!(String::from_utf8(output.stderr).unwrap().contains(
+            "error: the following required arguments were not provided:
+  --update"
+        ));
+    }
+
     fn cargo_afl<T: AsRef<OsStr>>(args: &[T]) -> Command {
         let mut command = command();
         command.arg("afl").args(args).env("NO_SUDO", "1");