Shrink derived code size with with_recursive_count.

The amount of code generated by `derive(Arbitrary)` is large, mostly due
to the recursion count guard. This commit factors out that code with a
new hidden function `with_recursive_count`.

Because `with_recursive_count` is mark with `inline`, the generated code
should end up being much the same. But compile times are reduced by
30-40% because rustc's frontend has much less code to chew through.

Author: nnethercote

derive/src/lib.rs

@@ -158,31 +158,6 @@ fn add_trait_bounds(mut generics: Generics, lifetime: LifetimeParam) -> Generics
     generics
 }
 
-fn with_recursive_count_guard(recursive_count: &syn::Ident, expr: TokenStream) -> TokenStream {
-    quote! {
-        let guard_against_recursion = u.is_empty();
-        if guard_against_recursion {
-            #recursive_count.with(|count| {
-                if count.get() > 0 {
-                    return Err(arbitrary::Error::NotEnoughData);
-                }
-                count.set(count.get() + 1);
-                Ok(())
-            })?;
-        }
-
-        let result = (|| { #expr })();
-
-        if guard_against_recursion {
-            #recursive_count.with(|count| {
-                count.set(count.get() - 1);
-            });
-        }
-
-        result
-    }
-}
-
 fn gen_arbitrary_method(
     input: &DeriveInput,
     lifetime: LifetimeParam,
@@ -195,11 +170,18 @@ fn gen_arbitrary_method(
         recursive_count: &syn::Ident,
     ) -> Result<TokenStream> {
         let arbitrary = construct(fields, |_idx, field| gen_constructor_for_field(field))?;
-        let body = with_recursive_count_guard(recursive_count, quote! { Ok(#ident #arbitrary) });
+        let body = quote! {
+            arbitrary::details::with_recursive_count(u, &#recursive_count, |mut u| {
+                Ok(#ident #arbitrary)
+            })
+        };
 
         let arbitrary_take_rest = construct_take_rest(fields)?;
-        let take_rest_body =
-            with_recursive_count_guard(recursive_count, quote! { Ok(#ident #arbitrary_take_rest) });
+        let take_rest_body = quote! {
+            arbitrary::details::with_recursive_count(u, &#recursive_count, |mut u| {
+                Ok(#ident #arbitrary_take_rest)
+            })
+        };
 
         Ok(quote! {
             fn arbitrary(u: &mut arbitrary::Unstructured<#lifetime>) -> arbitrary::Result<Self> {
@@ -243,7 +225,11 @@ fn gen_arbitrary_method(
         };
 
         if needs_recursive_count {
-            with_recursive_count_guard(recursive_count, do_variants)
+            quote! {
+                arbitrary::details::with_recursive_count(u, &#recursive_count, |mut u| {
+                    #do_variants
+                })
+            } 
         } else {
             do_variants
         }

src/lib.rs

@@ -551,3 +551,54 @@ mod test {
 /// ```
 #[cfg(all(doctest, feature = "derive"))]
 pub struct CompileFailTests;
+
+// Support for `#[derive(Arbitrary)]`.
+#[doc(hidden)]
+#[cfg(feature = "derive")]
+pub mod details {
+    use super::*;
+
+    // Hidden trait that papers over the difference between `&mut Unstructured` and
+    // `Unstructured` arguments so that `with_recursive_count` can be used for both
+    // `arbitrary` and `arbitrary_take_rest`.
+    pub trait IsEmpty {
+        fn is_empty(&self) -> bool;
+    }
+
+    impl IsEmpty for Unstructured<'_> {
+        fn is_empty(&self) -> bool { Unstructured::is_empty(self) }
+    }
+
+    impl IsEmpty for &mut Unstructured<'_> {
+        fn is_empty(&self) -> bool { Unstructured::is_empty(self) }
+    }
+
+    // Calls `f` with a recursive count guard.
+    #[inline]
+    pub fn with_recursive_count<U: IsEmpty, R>(
+        u: U,
+        recursive_count: &'static std::thread::LocalKey<std::cell::Cell<u32>>,
+        f: impl FnOnce(U) -> Result<R>,
+    ) -> Result<R> {
+        let guard_against_recursion = u.is_empty();
+        if guard_against_recursion {
+            recursive_count.with(|count| {
+                if count.get() > 0 {
+                    return Err(Error::NotEnoughData);
+                }
+                count.set(count.get() + 1);
+                Ok(())
+            })?;
+        }
+
+        let result = f(u);
+
+        if guard_against_recursion {
+            recursive_count.with(|count| {
+                count.set(count.get() - 1);
+            });
+        }
+
+        result
+    }
+}