Merge pull request #15 from Rimpampa/main

lmammino · web-flow · commit 77d5e8374b2b · 2021-11-24T09:55:27.000Z
Remove possible panic on remove_prefix
diff --git a/src/parse.rs b/src/parse.rs
@@ -75,8 +75,8 @@ fn remove_prefix(data: &'_ str) -> Result<&'_ str, ParseError> {
     }
 
     // check HC1: header
-    if &data[0..4] != "HC1:" {
-        return Err(ParseError::InvalidPrefix(String::from(&data[0..3])));
+    if !data.starts_with("HC1:") {
+        return Err(ParseError::InvalidPrefix(data.chars().take(4).collect()));
     }
 
     Ok(&data[4..])

Original file line number	Diff line number	Diff line change
`@@ -75,8 +75,8 @@ fn remove_prefix(data: &'_ str) -> Result<&'_ str, ParseError> {`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`// check HC1: header`
`78`		`- if &data[0..4] != "HC1:" {`
`79`		`- return Err(ParseError::InvalidPrefix(String::from(&data[0..3])));`
	`78`	`+ if !data.starts_with("HC1:") {`
	`79`	`+ return Err(ParseError::InvalidPrefix(data.chars().take(4).collect()));`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`Ok(&data[4..])`