Merge #445

445: Try temporary fix for CI r=jswrenn a=phimuemue

Unfortunately, I was not able to implement the idea @jswrenn suggested in #444 (comment) (having an optional `dev-dependency` seems to be a problem).

Thus, I adapted @jswrenn's attempt from 3f9e669 so that our MSRV only `build`s while stable/beta/nightly also test and bench.

To be honest, this feels pretty unsastisfactorily, but it may for now be a viable option that avoids blocking all PRs just because of a compilation error in a `dev-dependency`. Another possibility might be to downgrade `criterion`'s version (or abandon `criterion` altogether), both not particularly appealing imho.

When releasing a new version, we could still try to have one test/bench run on our MSVC (possibly with a manually adjusted `criterion` version).

(Sorry for all the noise from my side, but I'd really like to settle these kinds of problems so that we enable people to contribute without much inconvenience.)

Co-authored-by: philipp <[email protected]>

Author: bors[bot]

.travis.yml

@@ -3,19 +3,35 @@ sudo: false
 matrix:
   include:
     - rust: 1.32.0
+      script:
+        - |
+            cargo build --verbose --no-default-features &&
+            cargo build --verbose --features "$FEATURES"
     - rust: stable
+      script:
+        - |
+            cargo build --verbose --no-default-features &&
+            cargo build --verbose --features "$FEATURES" &&
+            cargo test --verbose --features "$FEATURES" &&
+            cargo bench --no-run --verbose --features "$FEATURES"
     - rust: beta
+      script:
+        - |
+            cargo build --verbose --no-default-features &&
+            cargo build --verbose --features "$FEATURES" &&
+            cargo test --verbose --features "$FEATURES" &&
+            cargo bench --no-run --verbose --features "$FEATURES"
     - rust: nightly
+      script:
+        - |
+            cargo build --verbose --no-default-features &&
+            cargo build --verbose --features "$FEATURES" &&
+            cargo test --verbose --features "$FEATURES" &&
+            cargo bench --no-run --verbose --features "$FEATURES"
 cache: cargo # https://docs.travis-ci.com/user/languages/rust/#dependency-management
 branches:
   only:
     - master
     # bors branches
     - staging
     - trying
-script:
-  - |
-      cargo build --verbose --no-default-features &&
-      cargo build --verbose --features "$FEATURES" &&
-      cargo test --verbose --features "$FEATURES" &&
-      cargo bench --no-run --verbose --features "$FEATURES"

Cargo.toml

@@ -27,7 +27,7 @@ either = { version = "1.0", default-features = false }
 
 [dev-dependencies]
 rand = "0.7"
-criterion = "=0.3.0" # TODO update criterion version once it becomes compatible with our minimum required Rust verision or bump minimum required rust version
+criterion = "=0" # TODO how could this work with our minimum supported rust version?
 
 [dev-dependencies.quickcheck]
 version = "0.9"