Make "cargo-semver-checks" action faster #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #938 +/- ##
==========================================
+ Coverage 94.38% 94.55% +0.17%
==========================================
Files 48 49 +1
Lines 6665 7002 +337
==========================================
+ Hits 6291 6621 +330
- Misses 374 381 +7 ☔ View full report in Codecov by Sentry. |
Philippe-Cholet
force-pushed
the
slow-semver-check
branch
from
640c79f to
e3c849f
Compare
jswrenn
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"cargo-semver-checks-action" previously took 2mn30s in CI which sure is not that much but is still slower than all the rest. It was slowly (PR after PR) driving me nuts.
After installing
cargo-semver-checkslocally, I witnessed that run the binary was fast. I eventually looked at the CI log and I thought the installation of the toolchain could be the bottleneck.For it (and other things), the semver-checks action uses "actions-rs/core" which has been recently archived and is therefore unmaintained and might be not as performant as alternatives.
So here, I install it with
dtolnay/rust-toolchain@stable(same as other jobs) and set the toolchain to "manual" for "cargo-semver-checks-action". And now it's 🚀blazingly fast🔥!tldr; CI is overall twice faster.