Macro hygiene: chain! and qualified paths
#943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If someone has a module named `core` and uses `itertools::chain!` then there is a conflict! I improve our macro hygiene test by adding (empty) modules with all the names we might be tempted to use. Without changing `core` in `chain!`, the test failed!
Is conflict with `.map` and `.zip` absolutely impossible?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #943 +/- ##
==========================================
- Coverage 94.38% 94.35% -0.03%
==========================================
Files 48 49 +1
Lines 6665 7002 +337
==========================================
+ Hits 6291 6607 +316
- Misses 374 395 +21 ☔ View full report in Codecov by Sentry. |
jswrenn
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#942 lead me to check our macro hygiene.
coreand usesitertools::chain!then there is a conflict!I improve our macro hygiene test by adding (empty) modules with all the names we might be tempted to use.
Without changing
coreinchain!, the test failed!.mapand.zipabsolutely impossible? Seems more bulletproof to me that way.EDIT: Found Add a chain! macro. #525 (comment) which seems to indicate I'm right to use qualified paths.
PS: This is my 💯th merged PR. 🎉