Skip to content

Allow Q: ?Sized in Itertools::contains #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2024
Merged

Allow Q: ?Sized in Itertools::contains #971

merged 1 commit into from
Jul 12, 2024

Conversation

@Alexendoo
Copy link
Contributor

@Alexendoo Alexendoo commented Jul 12, 2024

To enable .contains("foo") on an Iterator<Item = String> and similar

@codecov
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.32%. Comparing base (6814180) to head (ccd68d2).
Report is 111 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #971      +/-   ##
==========================================
- Coverage   94.38%   94.32%   -0.07%     
==========================================
  Files          48       49       +1     
  Lines        6665     6708      +43     
==========================================
+ Hits         6291     6327      +36     
- Misses        374      381       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

phimuemue
phimuemue approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@phimuemue phimuemue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@phimuemue phimuemue added this pull request to the merge queue Jul 12, 2024
Merged via the queue into rust-itertools:master with commit a20444f Jul 12, 2024
@Alexendoo Alexendoo deleted the contains-sized branch July 12, 2024 19:36
@Philippe-Cholet Philippe-Cholet added this to the next milestone Jul 12, 2024
facebook-github-bot pushed a commit to facebookincubator/below that referenced this pull request Jan 2, 2025
@ship-it-ship-it @facebook-github-bot
update itertools: 13.0.0 -> 14.0.0
928464f 
Summary:
[Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite:

 {F1974159737}

Differential Revision: D67751950

fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
facebook-github-bot pushed a commit to facebook/sapling that referenced this pull request Jan 2, 2025
@ship-it-ship-it @facebook-github-bot
update itertools: 13.0.0 -> 14.0.0
4b56f44 
Summary:
[Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite:

 {F1974159737}

Differential Revision: D67751950

fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
facebook-github-bot pushed a commit to facebookexperimental/rust-shed that referenced this pull request Jan 2, 2025
@ship-it-ship-it @facebook-github-bot
update itertools: 13.0.0 -> 14.0.0
61d5f20 
Summary:
[Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite:

 {F1974159737}

Differential Revision: D67751950

fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
facebook-github-bot pushed a commit to facebookincubator/reindeer that referenced this pull request Jan 2, 2025
@ship-it-ship-it @facebook-github-bot
update itertools: 13.0.0 -> 14.0.0
b302c5f 
Summary:
[Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite:

 {F1974159737}

Differential Revision: D67751950

fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
facebook-github-bot pushed a commit to facebook/hhvm that referenced this pull request Jan 2, 2025
@ship-it-ship-it @facebook-github-bot
update itertools: 13.0.0 -> 14.0.0
6e41ca5 
Summary:
[Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite:

 {F1974159737}

Differential Revision: D67751950

fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
facebook-github-bot pushed a commit to facebook/errpy that referenced this pull request Jan 2, 2025
@ship-it-ship-it @facebook-github-bot
update itertools: 13.0.0 -> 14.0.0
053ff58 
Summary:
[Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite:

 {F1974159737}

Differential Revision: D67751950

fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
facebook-github-bot pushed a commit to facebook/pyre-check that referenced this pull request Jan 2, 2025
@ship-it-ship-it @facebook-github-bot
update itertools: 13.0.0 -> 14.0.0
895e4aa 
Summary:
[Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite:

 {F1974159737}

Differential Revision: D67751950

fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
stroxler pushed a commit to facebook/pyrefly that referenced this pull request Mar 4, 2025
@ship-it-ship-it @facebook-github-bot
update itertools: 13.0.0 -> 14.0.0
db20442 
Summary:
[Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite:

 {F1974159737}

Differential Revision: D67751950

fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
stroxler pushed a commit to facebook/pyrefly that referenced this pull request Mar 4, 2025
@ship-it-ship-it @stroxler
update itertools: 13.0.0 -> 14.0.0
392ae0f 
Summary:
[Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite:

 {F1974159737}

Differential Revision: D67751950

fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
stroxler pushed a commit to facebook/pyre-check that referenced this pull request Mar 5, 2025
@ship-it-ship-it @facebook-github-bot
update itertools: 13.0.0 -> 14.0.0
b5df13e 
Summary:
[Changes](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md) to be aware of, with [971](rust-itertools/itertools#971) as my favourite:

 {F1974159737}

Differential Revision: D67751950

fbshipit-source-id: d5e39b7c685840b40aa7ba1b5015e8ccaea32b72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phimuemue phimuemue phimuemue approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

3 participants

@Alexendoo @phimuemue @Philippe-Cholet