Skip to content

Conversation

@phimuemue
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.25%. Comparing base (6814180) to head (6433dd7).
Report is 115 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
- Coverage   94.38%   94.25%   -0.14%     
==========================================
  Files          48       49       +1     
  Lines        6665     6702      +37     
==========================================
+ Hits         6291     6317      +26     
- Misses        374      385      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phimuemue
Copy link
Member Author

I'm unsure about the failing CI: Is the problem that ConsTuples required 2 generic arguments, whereas now it only needs 1? If so, I'd be tempted to accept this.

@phimuemue phimuemue enabled auto-merge August 22, 2024 10:48
Copy link
Member

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a breaking change queued up anyways for our MSRV bump, so the breaking change in this PR is a non-issue.

@phimuemue phimuemue added this pull request to the merge queue Aug 23, 2024
Merged via the queue into rust-itertools:master with commit e2a0a6e Aug 23, 2024
@phimuemue phimuemue deleted the cons_tuples_is_map_special_case branch August 23, 2024 12:36
@jswrenn jswrenn added this to the next milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants