Skip to content

Commit 13e5dd6

Browse files
astonbitecodeastonbitecode
committed
Usability improvemets:
* The User may copy the password even when not editing. * Made the description a text area. * Bumped version 0.4.1
1 parent f316aff commit 13e5dd6

File tree

4 files changed

+290
-278
lines changed

4 files changed

+290
-278
lines changed

‎java/pom.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
<groupId>org.astonbitecode.rustkeylock</groupId>
66
<artifactId>rust-keylock-android</artifactId>
7-
<version>0.4.0</version>
7+
<version>0.4.1</version>
88
<packaging>apk</packaging>
99

1010
<name>rust-keylock-android</name>

‎java/res/layout/fragment_show_entry.xml‎

Lines changed: 112 additions & 111 deletions
Original file line numberDiff line numberDiff line change
@@ -1,150 +1,151 @@
11
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
2-
xmlns:tools="http://schemas.android.com/tools"
3-
android:id="@+id/ShowEntryLayout"
4-
android:layout_width="fill_parent"
5-
android:layout_height="fill_parent"
6-
android:layout_gravity="center"
7-
android:gravity="top"
8-
android:orientation="vertical"
9-
android:paddingBottom="@dimen/activity_vertical_margin"
10-
android:paddingLeft="@dimen/activity_horizontal_margin"
11-
android:paddingRight="@dimen/activity_horizontal_margin"
12-
android:paddingTop="@dimen/activity_vertical_margin"
13-
tools:context="org.astonbitecode.rustkeylock.MainActivity" >
2+
xmlns:tools="http://schemas.android.com/tools"
3+
android:id="@+id/ShowEntryLayout"
4+
android:layout_width="fill_parent"
5+
android:layout_height="fill_parent"
6+
android:layout_gravity="center"
7+
android:gravity="top"
8+
android:orientation="vertical"
9+
android:paddingBottom="@dimen/activity_vertical_margin"
10+
android:paddingLeft="@dimen/activity_horizontal_margin"
11+
android:paddingRight="@dimen/activity_horizontal_margin"
12+
android:paddingTop="@dimen/activity_vertical_margin"
13+
tools:context="org.astonbitecode.rustkeylock.MainActivity">
1414

1515
<ScrollView
16-
android:id="@+id/scrollViewShowEntry"
17-
android:layout_width="match_parent"
18-
android:layout_height="match_parent" >
16+
android:id="@+id/scrollViewShowEntry"
17+
android:layout_width="match_parent"
18+
android:layout_height="match_parent">
1919

2020
<LinearLayout
21-
android:layout_width="match_parent"
22-
android:layout_height="match_parent"
23-
android:orientation="vertical" >
21+
android:layout_width="match_parent"
22+
android:layout_height="match_parent"
23+
android:orientation="vertical">
2424

2525
<TextView
26-
android:id="@+id/showEntryLabel"
27-
android:layout_width="wrap_content"
28-
android:layout_height="wrap_content"
29-
android:layout_gravity="center"
30-
android:text="Password Details"
31-
android:textAppearance="?android:attr/textAppearanceLarge" />
26+
android:id="@+id/showEntryLabel"
27+
android:layout_width="wrap_content"
28+
android:layout_height="wrap_content"
29+
android:layout_gravity="center"
30+
android:text="Password Details"
31+
android:textAppearance="?android:attr/textAppearanceLarge"/>
3232

3333
<TextView
34-
android:id="@+id/nameLabel"
35-
android:layout_width="wrap_content"
36-
android:layout_height="wrap_content"
37-
android:layout_marginTop="20sp"
38-
android:text="Entry Title"
39-
android:textAppearance="?android:attr/textAppearanceSmall" />
34+
android:id="@+id/nameLabel"
35+
android:layout_width="wrap_content"
36+
android:layout_height="wrap_content"
37+
android:layout_marginTop="20sp"
38+
android:text="Entry Title"
39+
android:textAppearance="?android:attr/textAppearanceSmall"/>
4040

4141
<EditText
42-
android:id="@+id/editName"
43-
android:layout_width="match_parent"
44-
android:layout_height="wrap_content"
45-
android:inputType="text" />
42+
android:id="@+id/editName"
43+
android:layout_width="match_parent"
44+
android:layout_height="wrap_content"
45+
android:inputType="text"/>
4646

4747
<TextView
48-
android:id="@+id/userLabel"
49-
android:layout_width="wrap_content"
50-
android:layout_height="wrap_content"
51-
android:layout_marginTop="10sp"
52-
android:text="Username"
53-
android:textAppearance="?android:attr/textAppearanceSmall" />
48+
android:id="@+id/userLabel"
49+
android:layout_width="wrap_content"
50+
android:layout_height="wrap_content"
51+
android:layout_marginTop="10sp"
52+
android:text="Username"
53+
android:textAppearance="?android:attr/textAppearanceSmall"/>
5454

5555
<EditText
56-
android:id="@+id/editUser"
57-
android:layout_width="match_parent"
58-
android:layout_height="wrap_content"
59-
android:inputType="text" />
56+
android:id="@+id/editUser"
57+
android:layout_width="match_parent"
58+
android:layout_height="wrap_content"
59+
android:inputType="text"/>
6060

6161
<TextView
62-
android:id="@+id/passwordLabel"
63-
android:layout_width="wrap_content"
64-
android:layout_height="wrap_content"
65-
android:layout_marginTop="10sp"
66-
android:text="Password"
67-
android:textAppearance="?android:attr/textAppearanceSmall" />
62+
android:id="@+id/passwordLabel"
63+
android:layout_width="wrap_content"
64+
android:layout_height="wrap_content"
65+
android:layout_marginTop="10sp"
66+
android:text="Password"
67+
android:textAppearance="?android:attr/textAppearanceSmall"/>
6868

6969
<EditText
70-
android:id="@+id/editPassword"
71-
android:layout_width="match_parent"
72-
android:layout_height="wrap_content"
73-
android:inputType="text" />
70+
android:id="@+id/editPassword"
71+
android:layout_width="match_parent"
72+
android:layout_height="wrap_content"
73+
android:inputType="text"/>
7474

7575
<TextView
76-
android:id="@+id/nameDescription"
77-
android:layout_width="wrap_content"
78-
android:layout_height="wrap_content"
79-
android:layout_marginTop="10sp"
80-
android:text="Description"
81-
android:textAppearance="?android:attr/textAppearanceSmall" />
76+
android:id="@+id/nameDescription"
77+
android:layout_width="wrap_content"
78+
android:layout_height="wrap_content"
79+
android:layout_marginTop="10sp"
80+
android:text="Description"
81+
android:textAppearance="?android:attr/textAppearanceSmall"/>
8282

8383
<EditText
84-
android:id="@+id/editDescription"
85-
android:layout_width="match_parent"
86-
android:layout_height="wrap_content"
87-
android:inputType="text"
88-
android:paddingBottom="10sp" />
84+
android:id="@+id/editDescriptionArea"
85+
android:layout_width="match_parent"
86+
android:layout_height="wrap_content"
87+
android:inputType="textMultiLine"
88+
android:gravity="left|top"
89+
android:paddingBottom="11sp"/>
8990

9091
<GridLayout
91-
android:layout_width="match_parent"
92-
android:layout_height="wrap_content"
93-
android:layout_gravity="center"
94-
android:layout_marginTop="20sp"
95-
android:columnCount="2"
96-
android:gravity="center|top"
97-
android:orientation="horizontal" >
92+
android:layout_width="match_parent"
93+
android:layout_height="wrap_content"
94+
android:layout_gravity="center"
95+
android:layout_marginTop="20sp"
96+
android:columnCount="2"
97+
android:gravity="center|top"
98+
android:orientation="horizontal">
9899

99100
<Button
100-
android:id="@+id/editButton"
101-
android:layout_width="wrap_content"
102-
android:layout_height="wrap_content"
103-
android:layout_gravity="left"
104-
android:background="@android:color/transparent"
105-
android:drawableTop="@drawable/edit"
106-
android:text="Edit" />
101+
android:id="@+id/editButton"
102+
android:layout_width="wrap_content"
103+
android:layout_height="wrap_content"
104+
android:layout_gravity="left"
105+
android:background="@android:color/transparent"
106+
android:drawableTop="@drawable/edit"
107+
android:text="Edit"/>
107108

108109
<Button
109-
android:id="@+id/deleteButton"
110-
android:layout_width="wrap_content"
111-
android:layout_height="wrap_content"
112-
android:layout_gravity="right"
113-
android:background="@android:color/transparent"
114-
android:drawableTop="@drawable/delete"
115-
android:text="Delete" />
110+
android:id="@+id/deleteButton"
111+
android:layout_width="wrap_content"
112+
android:layout_height="wrap_content"
113+
android:layout_gravity="right"
114+
android:background="@android:color/transparent"
115+
android:drawableTop="@drawable/delete"
116+
android:text="Delete"/>
116117
</GridLayout>
117118

118119
<GridLayout
119-
android:layout_width="match_parent"
120-
android:layout_height="wrap_content"
121-
android:layout_gravity="center"
122-
android:layout_marginTop="20sp"
123-
android:columnCount="2"
124-
android:gravity="center|top"
125-
android:orientation="horizontal" >
120+
android:layout_width="match_parent"
121+
android:layout_height="wrap_content"
122+
android:layout_gravity="center"
123+
android:layout_marginTop="20sp"
124+
android:columnCount="2"
125+
android:gravity="center|top"
126+
android:orientation="horizontal">
126127

127128
<Button
128-
android:id="@+id/updateButton"
129-
android:layout_width="wrap_content"
130-
android:layout_height="wrap_content"
131-
android:layout_columnSpan="2"
132-
android:layout_gravity="right"
133-
android:layout_marginTop="10sp"
134-
android:background="@android:color/transparent"
135-
android:drawableTop="@drawable/save"
136-
android:text="Save" />
129+
android:id="@+id/updateButton"
130+
android:layout_width="wrap_content"
131+
android:layout_height="wrap_content"
132+
android:layout_columnSpan="2"
133+
android:layout_gravity="right"
134+
android:layout_marginTop="10sp"
135+
android:background="@android:color/transparent"
136+
android:drawableTop="@drawable/save"
137+
android:text="Save"/>
137138

138139
<Button
139-
android:id="@+id/areYouSureButton"
140-
android:layout_width="wrap_content"
141-
android:layout_height="wrap_content"
142-
android:layout_columnSpan="2"
143-
android:layout_gravity="right"
144-
android:layout_marginTop="10sp"
145-
android:background="@android:color/transparent"
146-
android:drawableTop="@drawable/caution"
147-
android:text="Yes, I am sure... Delete it!" />
140+
android:id="@+id/areYouSureButton"
141+
android:layout_width="wrap_content"
142+
android:layout_height="wrap_content"
143+
android:layout_columnSpan="2"
144+
android:layout_gravity="right"
145+
android:layout_marginTop="10sp"
146+
android:background="@android:color/transparent"
147+
android:drawableTop="@drawable/caution"
148+
android:text="Yes, I am sure... Delete it!"/>
148149
</GridLayout>
149150
</LinearLayout>
150151
</ScrollView>

0 commit comments

Comments
 (0)