Do not talk about "trait <Foo = Bar>"

estebank · estebank · commit 6b758e2ae39b · 2024-11-28T23:44:02.000Z
Pass in an appropriate `Option&lt;DefId&gt;` in more cases from hir ty lowering.
diff --git a/compiler/rustc_hir_analysis/src/hir_ty_lowering/errors.rs b/compiler/rustc_hir_analysis/src/hir_ty_lowering/errors.rs
@@ -279,7 +279,13 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
                     } else {
                         let mut err = self.dcx().create_err(err);
                         if suggest_constraining_type_param(
-                            tcx, generics, &mut err, &qself_str, &trait_ref, None, None,
+                            tcx,
+                            generics,
+                            &mut err,
+                            &qself_str,
+                            &trait_ref,
+                            Some(best_trait),
+                            None,
                         ) && !identically_named
                         {
                             // We suggested constraining a type parameter, but the associated item on it
diff --git a/compiler/rustc_middle/src/ty/diagnostics.rs b/compiler/rustc_middle/src/ty/diagnostics.rs
@@ -345,6 +345,7 @@ pub fn suggest_constraining_type_params<'a>(
         let mut constraint = constraints.iter().map(|&(c, _, _)| c).collect::<Vec<_>>();
         constraint.sort();
         constraint.dedup();
+        let all_known = constraints.iter().all(|&(_, def_id, _)| def_id.is_some());
         let all_stable = constraints.iter().all(|&(_, _, stable)| stable.is_empty());
         let all_unstable = constraints.iter().all(|&(_, _, stable)| !stable.is_empty());
         let post = if all_stable || all_unstable {
@@ -360,7 +361,8 @@ pub fn suggest_constraining_type_params<'a>(
             trait_names.dedup();
             let n = trait_names.len();
             let stable = if all_stable { "" } else { "unstable " };
-            format!("{stable}trait{} {}", pluralize!(n), match &trait_names[..] {
+            let trait_ = if all_known { "trait" } else { "" };
+            format!("{stable}{trait_}{} {}", pluralize!(n), match &trait_names[..] {
                 [t] => t.to_string(),
                 [ts @ .., last] => format!("{} and {last}", ts.join(", ")),
                 [] => return false,
@@ -370,7 +372,7 @@ pub fn suggest_constraining_type_params<'a>(
             let mut trait_names = constraints
                 .iter()
                 .map(|&(c, def_id, stable)| match def_id {
-                    None => format!("{stable}trait `{c}`"),
+                    None => format!("`{c}`"),
                     Some(def_id) => format!("{stable}trait `{}`", tcx.item_name(def_id)),
                 })
                 .collect::<Vec<_>>();
diff --git a/tests/ui/associated-types/hr-associated-type-projection-1.stderr b/tests/ui/associated-types/hr-associated-type-projection-1.stderr
@@ -16,7 +16,7 @@ LL | trait UnsafeCopy<'a, T: Copy>
 LL | where
 LL |     for<'b> <Self as UnsafeCopy<'b, T>>::Item: std::ops::Deref<Target = T>,
    |                                                                ^^^^^^^^^^ required by this bound in `UnsafeCopy`
-help: consider further restricting this bound with trait `<Target = T>`
+help: consider further restricting this bound with  `<Target = T>`
    |
 LL | impl<T: Copy + std::ops::Deref<Target = T>> UnsafeCopy<'_, T> for T {
    |                               ++++++++++++
diff --git a/tests/ui/generic-associated-types/issue-68656-unsized-values.stderr b/tests/ui/generic-associated-types/issue-68656-unsized-values.stderr
@@ -13,7 +13,7 @@ note: required by a bound in `UnsafeCopy::Item`
    |
 LL |     type Item<'a>: std::ops::Deref<Target = T>;
    |                                    ^^^^^^^^^^ required by this bound in `UnsafeCopy::Item`
-help: consider further restricting this bound with trait `<Target = T>`
+help: consider further restricting this bound with  `<Target = T>`
    |
 LL | impl<T: Copy + std::ops::Deref<Target = T>> UnsafeCopy<T> for T {
    |                               ++++++++++++
diff --git a/tests/ui/generic-associated-types/missing-bounds.stderr b/tests/ui/generic-associated-types/missing-bounds.stderr
@@ -35,7 +35,7 @@ note: tuple struct defined here
    |
 LL | struct A<B>(B);
    |        ^
-help: consider further restricting this bound with trait `<Output = B>`
+help: consider further restricting this bound with  `<Output = B>`
    |
 LL | impl<B> Add for A<B> where B: Add<Output = B> {
    |                                  ++++++++++++
@@ -58,7 +58,7 @@ note: tuple struct defined here
    |
 LL | struct C<B>(B);
    |        ^
-help: consider further restricting this bound with trait `<Output = B>`
+help: consider further restricting this bound with  `<Output = B>`
    |
 LL | impl<B: Add<Output = B>> Add for C<B> {
    |            ++++++++++++
@@ -94,7 +94,7 @@ note: tuple struct defined here
    |
 LL | struct E<B>(B);
    |        ^
-help: consider further restricting this bound with trait `<Output = B>`
+help: consider further restricting this bound with  `<Output = B>`
    |
 LL | impl<B: Add<Output = B>> Add for E<B> where <B as Add>::Output = B {
    |            ++++++++++++
diff --git a/tests/ui/moves/use_of_moved_value_copy_suggestions.fixed b/tests/ui/moves/use_of_moved_value_copy_suggestions.fixed
@@ -48,22 +48,22 @@ fn duplicate_custom_1<T: Copy + Trait>(t: S<T>) -> (S<T>, S<T>) where {
 fn duplicate_custom_2<T>(t: S<T>) -> (S<T>, S<T>)
 where
     T: A + Copy + Trait,
-    //~^ HELP consider further restricting this bound
+    //~^ HELP consider further restricting
 {
     (t, t) //~ use of moved value: `t`
 }
 
 fn duplicate_custom_3<T>(t: S<T>) -> (S<T>, S<T>)
 where
     T: A + Copy + Trait,
-    //~^ HELP consider further restricting this bound
+    //~^ HELP consider further restricting
     T: B,
 {
     (t, t) //~ use of moved value: `t`
 }
 
 fn duplicate_custom_4<T: A + Copy + Trait>(t: S<T>) -> (S<T>, S<T>)
-//~^ HELP consider further restricting this bound
+//~^ HELP consider further restricting
 where
     T: B,
 {
diff --git a/tests/ui/moves/use_of_moved_value_copy_suggestions.rs b/tests/ui/moves/use_of_moved_value_copy_suggestions.rs
@@ -48,22 +48,22 @@ fn duplicate_custom_1<T>(t: S<T>) -> (S<T>, S<T>) where {
 fn duplicate_custom_2<T>(t: S<T>) -> (S<T>, S<T>)
 where
     T: A,
-    //~^ HELP consider further restricting this bound
+    //~^ HELP consider further restricting
 {
     (t, t) //~ use of moved value: `t`
 }
 
 fn duplicate_custom_3<T>(t: S<T>) -> (S<T>, S<T>)
 where
     T: A,
-    //~^ HELP consider further restricting this bound
+    //~^ HELP consider further restricting
     T: B,
 {
     (t, t) //~ use of moved value: `t`
 }
 
 fn duplicate_custom_4<T: A>(t: S<T>) -> (S<T>, S<T>)
-//~^ HELP consider further restricting this bound
+//~^ HELP consider further restricting
 where
     T: B,
 {
diff --git a/tests/ui/suggestions/restrict-existing-type-bounds.stderr b/tests/ui/suggestions/restrict-existing-type-bounds.stderr
@@ -20,7 +20,7 @@ LL |         Ok(self)
    |            this argument influences the type of `Ok`
 note: tuple variant defined here
   --> $SRC_DIR/core/src/result.rs:LL:COL
-help: consider further restricting this bound with trait `<Output = T>`
+help: consider further restricting this bound with  `<Output = T>`
    |
 LL | impl<T: TryAdd<Output = T>> TryAdd for Option<T> {
    |               ++++++++++++
@@ -47,7 +47,7 @@ LL |         Ok(self)
    |            this argument influences the type of `Ok`
 note: tuple variant defined here
   --> $SRC_DIR/core/src/result.rs:LL:COL
-help: consider further restricting this bound with trait `, Output = T`
+help: consider further restricting this bound with  `, Output = T`
    |
 LL | impl<T: TryAdd<Error = X, Output = T>> TryAdd for Other<T> {
    |                         ++++++++++++
diff --git a/tests/ui/trait-bounds/restrict-assoc-type-of-generic-bound.stderr b/tests/ui/trait-bounds/restrict-assoc-type-of-generic-bound.stderr
@@ -11,7 +11,7 @@ LL |     return a.bar();
    = note: expected type parameter `B`
              found associated type `<A as MyTrait>::T`
    = note: the caller chooses a type for `B` which can be different from `<A as MyTrait>::T`
-help: consider further restricting this bound with trait `<T = B>`
+help: consider further restricting this bound with  `<T = B>`
    |
 LL | pub fn foo<A: MyTrait<T = B>, B>(a: A) -> B {
    |                      +++++++
diff --git a/tests/ui/traits/copy-is-not-modulo-regions.not_static.stderr b/tests/ui/traits/copy-is-not-modulo-regions.not_static.stderr
@@ -12,7 +12,7 @@ note: the `Copy` impl for `Foo<'any>` requires that `'any: 'static`
    |
 LL | struct Bar<'lt>(Foo<'lt>);
    |                 ^^^^^^^^
-help: consider restricting type parameter `'any` with trait `'static`
+help: consider restricting type parameter `'any` with  `'static`
    |
 LL | impl<'any: 'static> Copy for Bar<'any> {}
    |          +++++++++
diff --git a/tests/ui/type-alias/unresolved-assoc-ty-suggest-trait.lazy.stderr b/tests/ui/type-alias/unresolved-assoc-ty-suggest-trait.lazy.stderr
@@ -30,7 +30,7 @@ error[E0220]: associated type `Proj` not found for `T`
 LL | type ProjOf<T> = T::Proj;
    |                     ^^^^ there is an associated type `Proj` in the trait `Parametrized`
    |
-help: consider restricting type parameter `T` with trait `Parametrized</* 'a, T, N */>`
+help: consider restricting type parameter `T` with trait `Parametrized`
    |
 LL | type ProjOf<T: Parametrized</* 'a, T, N */>> = T::Proj;
    |              ++++++++++++++++++++++++++++++

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ LL \| trait UnsafeCopy<'a, T: Copy>`
`16`	`16`	`LL \| where`
`17`	`17`	`LL \| for<'b> <Self as UnsafeCopy<'b, T>>::Item: std::ops::Deref<Target = T>,`
`18`	`18`	\| ^^^^^^^^^^ required by this bound in `UnsafeCopy`
`19`		-help: consider further restricting this bound with trait `<Target = T>`
	`19`	+help: consider further restricting this bound with `<Target = T>`
`20`	`20`	`\|`
`21`	`21`	`LL \| impl<T: Copy + std::ops::Deref<Target = T>> UnsafeCopy<'_, T> for T {`
`22`	`22`	`\| ++++++++++++`
Original file line number	Diff line number	Diff line change
@@ -13,7 +13,7 @@ note: required by a bound in `UnsafeCopy::Item`
`13`	`13`	`\|`
`14`	`14`	`LL \| type Item<'a>: std::ops::Deref<Target = T>;`
`15`	`15`	\| ^^^^^^^^^^ required by this bound in `UnsafeCopy::Item`
`16`		-help: consider further restricting this bound with trait `<Target = T>`
	`16`	+help: consider further restricting this bound with `<Target = T>`
`17`	`17`	`\|`
`18`	`18`	`LL \| impl<T: Copy + std::ops::Deref<Target = T>> UnsafeCopy<T> for T {`
`19`	`19`	`\| ++++++++++++`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ note: tuple struct defined here`
`35`	`35`	`\|`
`36`	`36`	`LL \| struct A<B>(B);`
`37`	`37`	`\| ^`
`38`		-help: consider further restricting this bound with trait `<Output = B>`
	`38`	+help: consider further restricting this bound with `<Output = B>`
`39`	`39`	`\|`
`40`	`40`	`LL \| impl<B> Add for A<B> where B: Add<Output = B> {`
`41`	`41`	`\| ++++++++++++`
`@@ -58,7 +58,7 @@ note: tuple struct defined here`
`58`	`58`	`\|`
`59`	`59`	`LL \| struct C<B>(B);`
`60`	`60`	`\| ^`
`61`		-help: consider further restricting this bound with trait `<Output = B>`
	`61`	+help: consider further restricting this bound with `<Output = B>`
`62`	`62`	`\|`
`63`	`63`	`LL \| impl<B: Add<Output = B>> Add for C<B> {`
`64`	`64`	`\| ++++++++++++`
`@@ -94,7 +94,7 @@ note: tuple struct defined here`
`94`	`94`	`\|`
`95`	`95`	`LL \| struct E<B>(B);`
`96`	`96`	`\| ^`
`97`		-help: consider further restricting this bound with trait `<Output = B>`
	`97`	+help: consider further restricting this bound with `<Output = B>`
`98`	`98`	`\|`
`99`	`99`	`LL \| impl<B: Add<Output = B>> Add for E<B> where <B as Add>::Output = B {`
`100`	`100`	`\| ++++++++++++`
Original file line number	Diff line number	Diff line change
`@@ -48,22 +48,22 @@ fn duplicate_custom_1<T: Copy + Trait>(t: S<T>) -> (S<T>, S<T>) where {`
`48`	`48`	`fn duplicate_custom_2<T>(t: S<T>) -> (S<T>, S<T>)`
`49`	`49`	`where`
`50`	`50`	`T: A + Copy + Trait,`
`51`		`- //~^ HELP consider further restricting this bound`
	`51`	`+ //~^ HELP consider further restricting`
`52`	`52`	`{`
`53`	`53`	(t, t) //~ use of moved value: `t`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`fn duplicate_custom_3<T>(t: S<T>) -> (S<T>, S<T>)`
`57`	`57`	`where`
`58`	`58`	`T: A + Copy + Trait,`
`59`		`- //~^ HELP consider further restricting this bound`
	`59`	`+ //~^ HELP consider further restricting`
`60`	`60`	`T: B,`
`61`	`61`	`{`
`62`	`62`	(t, t) //~ use of moved value: `t`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`fn duplicate_custom_4<T: A + Copy + Trait>(t: S<T>) -> (S<T>, S<T>)`
`66`		`-//~^ HELP consider further restricting this bound`
	`66`	`+//~^ HELP consider further restricting`
`67`	`67`	`where`
`68`	`68`	`T: B,`
`69`	`69`	`{`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ LL \| return a.bar();`
`11`	`11`	= note: expected type parameter `B`
`12`	`12`	found associated type `<A as MyTrait>::T`
`13`	`13`	= note: the caller chooses a type for `B` which can be different from `<A as MyTrait>::T`
`14`		-help: consider further restricting this bound with trait `<T = B>`
	`14`	+help: consider further restricting this bound with `<T = B>`
`15`	`15`	`\|`
`16`	`16`	`LL \| pub fn foo<A: MyTrait<T = B>, B>(a: A) -> B {`
`17`	`17`	`\| +++++++`
Original file line number	Diff line number	Diff line change
@@ -12,7 +12,7 @@ note: the `Copy` impl for `Foo<'any>` requires that `'any: 'static`
`12`	`12`	`\|`
`13`	`13`	`LL \| struct Bar<'lt>(Foo<'lt>);`
`14`	`14`	`\| ^^^^^^^^`
`15`		-help: consider restricting type parameter `'any` with trait `'static`
	`15`	+help: consider restricting type parameter `'any` with `'static`
`16`	`16`	`\|`
`17`	`17`	`LL \| impl<'any: 'static> Copy for Bar<'any> {}`
`18`	`18`	`\| +++++++++`