Merge pull request #184 from obeis/duplicate-items

Add check for duplicate items in crate

Author: nikomatsakis

crates/formality-check/src/lib.rs

@@ -3,6 +3,7 @@
 use std::{collections::VecDeque, fmt::Debug};
 
 use anyhow::bail;
+use formality_core::Set;
 use formality_prove::{is_definitely_not_proveable, Decls, Env};
 use formality_rust::{
     grammar::{Crate, CrateItem, Program, Test, TestBoundData},
@@ -71,7 +72,38 @@ impl Check<'_> {
     }
 
     fn check_for_duplicate_items(&self) -> Fallible<()> {
-        // FIXME: check for items with duplicate names, respecting the various Rust rules about namespaces
+        let Program { crates } = &self.program;
+        for c in crates.iter() {
+            let mut items = Set::new();
+            let mut traits = Set::new();
+            let mut functions = Set::new();
+            for item in c.items.iter() {
+                match item {
+                    CrateItem::Struct(s) => {
+                        if !items.insert(&s.id) {
+                            bail!("the item name `{:?}` is defined multiple times", s.id);
+                        }
+                    }
+                    CrateItem::Enum(e) => {
+                        if !items.insert(&e.id) {
+                            bail!("the item name `{:?}` is defined multiple times", e.id);
+                        }
+                    }
+                    CrateItem::Trait(t) => {
+                        if !traits.insert(&t.id) {
+                            bail!("the trait name `{:?}` is defined multiple times", t.id);
+                        }
+                    }
+                    CrateItem::Fn(f) => {
+                        if !functions.insert(&f.id) {
+                            bail!("the function name `{:?}` is defined multiple times", f.id);
+                        }
+                    }
+                    CrateItem::TraitImpl(_) | CrateItem::NegTraitImpl(_) | CrateItem::Test(_) => {}
+                }
+            }
+        }
+
         Ok(())
     }
 

src/test/mod.rs

@@ -215,3 +215,61 @@ fn trait_items_with_duplicate_associated_type_names() {
                 the associated type name `Assoc` is defined multiple times"#]]
     );
 }
+
+#[test]
+fn crate_with_duplicate_item_names() {
+    crate::assert_err!(
+        [
+            crate core {
+                struct A {}
+
+                enum A {}
+            }
+        ]
+
+        ["the item name `A` is defined multiple times",]
+
+        expect_test::expect![[r#"the item name `A` is defined multiple times"#]]
+    );
+
+    crate::assert_err!(
+        [
+            crate core {
+                trait a {}
+
+                trait a {}
+            }
+        ]
+
+        ["the trait name `a` is defined multiple times",]
+
+        expect_test::expect![[r#"the trait name `a` is defined multiple times"#]]
+    );
+
+    crate::assert_err!(
+        [
+            crate core {
+                fn a() -> () { trusted }
+
+                fn a() -> () { trusted }
+            }
+        ]
+
+        ["the function name `a` is defined multiple times",]
+
+        expect_test::expect![[r#"the function name `a` is defined multiple times"#]]
+    );
+
+    crate::assert_ok!(
+        //@check-pass
+        [
+            crate core {
+                trait a {}
+
+                fn a() -> () { trusted }
+            }
+        ]
+
+        expect_test::expect!["()"]
+    );
+}