Remove coresymbolication implementation (#316)

* Remove coresymbolication implementation

This isn't used anywhere by default any more and I don't think there's
any reason to enable it. This older implementation uses private APIs
which aren't supposed to be used. Additionally libbacktrace nowadays
should be workable enough and with gimli soon on the horizon that should
be a suitable default for macOS and iOS.

* Disable android emulator in CI

Author: alexcrichton

.github/workflows/main.yml

@@ -65,12 +65,9 @@ jobs:
     - run: cargo test --no-default-features --features "libunwind dladdr std"
     - run: cargo test --no-default-features --features "libunwind libbacktrace std"
     - run: cargo test --no-default-features --features "libunwind libbacktrace dbghelp std"
-    - run: cargo test --no-default-features --features "libunwind coresymbolication dbghelp std"
-    - run: cargo test --no-default-features --features "libunwind coresymbolication dbghelp std libbacktrace"
     - run: cargo test --no-default-features --features "unix-backtrace std"
     - run: cargo test --no-default-features --features "unix-backtrace dladdr std"
     - run: cargo test --no-default-features --features "unix-backtrace libbacktrace std"
-    - run: cargo test --no-default-features --features "unix-backtrace coresymbolication std"
     - run: cargo test --no-default-features --features "serialize-serde std"
     - run: cargo test --no-default-features --features "serialize-rustc std"
     - run: cargo test --no-default-features --features "serialize-rustc serialize-serde std"
@@ -80,7 +77,6 @@ jobs:
     - run: cargo test --manifest-path crates/cpp_smoke_test/Cargo.toml
     - run: cargo test --manifest-path crates/macos_frames_test/Cargo.toml
     - run: cargo test --features libbacktrace --manifest-path crates/without_debuginfo/Cargo.toml
-    - run: cargo test --features "libbacktrace coresymbolication" --manifest-path crates/without_debuginfo/Cargo.toml
     - run: cargo test --features "libbacktrace gimli-symbolize" --manifest-path crates/without_debuginfo/Cargo.toml
     - run: cargo test --manifest-path crates/line-tables-only/Cargo.toml --features libbacktrace
     - run: cargo test --manifest-path crates/line-tables-only/Cargo.toml --features gimli-symbolize

Cargo.toml

@@ -84,17 +84,13 @@ kernel32 = []
 # - dladdr: this feature uses the dladdr(3) function (a glibc extension) to
 #   resolve symbol names. This is fairly unreliable on linux, but works well
 #   enough on OSX.
-# - coresymbolication: this feature uses the undocumented core symbolication
-#   framework on OS X to symbolize. Note that this is not turned on default due
-#   to various issues, you can see more in #202.
 # - gimli-symbolize: use the `gimli-rs/addr2line` crate to symbolicate
 #   addresses into file, line, and name using DWARF debug information. At
 #   the moment, this is only possible when targetting Linux, since macOS
 #   splits DWARF out into a separate object file. Enabling this feature
 #   means one less C dependency.
 libbacktrace = ["backtrace-sys/backtrace-sys"]
 dladdr = []
-coresymbolication = []
 gimli-symbolize = ["addr2line", "goblin"]
 
 #=======================================
@@ -104,6 +100,12 @@ gimli-symbolize = ["addr2line", "goblin"]
 serialize-rustc = ["rustc-serialize"]
 serialize-serde = ["serde"]
 
+#=======================================
+# Deprecated features
+#
+# Only here for backwards compatibility purposes, they do nothing now.
+coresymbolication = []
+
 #=======================================
 # Internal features for testing and such.
 verify-winapi = [

ci/docker/arm-linux-androideabi/Dockerfile

@@ -11,27 +11,8 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
 
 COPY android-ndk.sh /
 RUN /android-ndk.sh arm
-WORKDIR /android
-COPY android-sdk.sh /android/sdk.sh
-RUN ./sdk.sh arm
-RUN mv /root/.android /tmp
-RUN chmod 777 -R /tmp/.android
-RUN chmod 755 /android/sdk/tools/* /android/sdk/emulator/qemu/linux-x86_64/*
-ENV PATH=$PATH:/android-toolchain/bin:/android/sdk/platform-tools
+ENV PATH=$PATH:/android-toolchain/bin
 
 # TODO: run tests in an emulator eventually
 ENV CARGO_TARGET_ARM_LINUX_ANDROIDEABI_LINKER=arm-linux-androideabi-gcc \
-    CARGO_TARGET_ARM_LINUX_ANDROIDEABI_RUNNER=/tmp/runtest \
-    HOME=/tmp
-
-ADD runtest-android.rs /tmp/runtest.rs
-ENTRYPOINT [ \
-  "bash", \
-  "-c", \
-  # set SHELL so android can detect a 64bits system, see
-  # http://stackoverflow.com/a/41789144
-  "SHELL=/bin/dash /android/sdk/emulator/emulator @arm -no-window & \
-   /rust/bin/rustc /tmp/runtest.rs -o /tmp/runtest && \
-   exec \"$@\"", \
-  "--" \
-]
+    CARGO_TARGET_ARM_LINUX_ANDROIDEABI_RUNNER=echo

crates/without_debuginfo/Cargo.toml

@@ -27,5 +27,4 @@ debug = false
 
 [features]
 libbacktrace = ['backtrace/libbacktrace']
-coresymbolication = ['backtrace/coresymbolication']
 gimli-symbolize = ['backtrace/gimli-symbolize']

src/symbolize/coresymbolication.rs

@@ -476,16 +476,6 @@ cfg_if::cfg_if! {
         use self::gimli::resolve as resolve_imp;
         use self::gimli::Symbol as SymbolImp;
         use self::gimli::clear_symbol_cache as clear_symbol_cache_imp;
-    // Note that we only enable coresymbolication on iOS when debug assertions
-    // are enabled because it's helpful in debug mode but it looks like apps get
-    // rejected from the app store if they use this API, see #92 for more info
-    } else if #[cfg(all(feature = "coresymbolication",
-                        any(target_os = "macos",
-                            all(target_os = "ios", debug_assertions))))] {
-        mod coresymbolication;
-        use self::coresymbolication::resolve as resolve_imp;
-        use self::coresymbolication::Symbol as SymbolImp;
-        unsafe fn clear_symbol_cache_imp() {}
     } else if #[cfg(all(feature = "libbacktrace",
                         any(unix, all(windows, not(target_vendor = "uwp"), target_env = "gnu")),
                         not(target_os = "fuchsia"),

src/symbolize/mod.rs

@@ -7,7 +7,6 @@ where
 }
 
 #[inline(always)]
-#[cfg_attr(feature = "coresymbolication", inline(never))]
 pub fn callback_inlined<F>(f: F)
 where
     F: FnOnce((&'static str, u32)),