Skip to content

Commit 7e1acb0

Browse files
committed
fix: Check for uses of 'we'
1 parent 341ea8f commit 7e1acb0

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

content/inside-rust/this-development-cycle-in-cargo-1.90.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -285,8 +285,8 @@ The rest of the mechanics are more program specific.
285285
We talked a bit about Cargo's transition.
286286
We still plan to do this in two phases, (1) make the more granular paths configurable and then (2) change the defaults to OS native paths.
287287
The change to OS native paths might not even need to happen in one go so long as we've solve the policy questions (particularly for Mac).
288-
For config, we can read from both locations.
289-
For caches, we can abandon the old location though there is a question of how to handle the cache garbage collection database,
288+
For config, Cargo can read from both locations.
289+
For caches, Cargo can abandon the old location though there is a question of how to handle the cache garbage collection database,
290290
whether to have them be distinct or not.
291291
There is a question on how to transition the bin path.
292292

@@ -364,7 +364,7 @@ The Testing DevEx team has done some brainstorming on this problem
364364
- Building doctest support into the compiler,
365365
parsing `#[doc]` attributes and generating `#[test]` functions for them
366366
- Allows doctests on internal items and binary targets
367-
- Doesn't allow for the "pubic interface" testing unless we also link to the original lib or do some import path hackery
367+
- Doesn't allow for the "pubic interface" testing unless Rustc also links to the original lib or do some import path hackery
368368
- Has issues with features like `compile_fail` and per-doctest Editions
369369
- Using `rustdoc --output-format=doctest` to extract doctests, generate test files, build, and then run those ([rust#134529](https://github.com/rust-lang/rust/issues/134529))
370370

@@ -554,12 +554,12 @@ and having `cargo fix` apply it for the first time could be unwanted on its own
554554
A way to reduce unwanted edits is if we had an interface to tell `cargo fmt` to only re-format the parts changed by `cargo fix`.
555555
The exact interaction for these would have to be carefully considered and may still produce unwanted reformatting.
556556

557-
At the next level, we could have a [`.cargo/config.toml`](https://doc.rust-lang.org/cargo/reference/config.html) field
557+
At the next level, Cargo could have a [`.cargo/config.toml`](https://doc.rust-lang.org/cargo/reference/config.html) field
558558
```
559559
[fix]
560560
rustfmt = true
561561
```
562-
If we did this, we may want to run `cargo fmt --check` first,
562+
If we did this, we may want to have Cargo run `cargo fmt --check` first,
563563
similar to our "VCS dirty" check.
564564

565565
At a minimum, `cargo fix` could recommend running `cargo fmt` if changes were made.
@@ -609,7 +609,7 @@ This likely wouldn't be reconsidered until at least
609609
is addressed.
610610
We talked about the idea of caching the relative path inside of the `Cargo.lock`.
611611
If the package is no longer at that path (update of `git` dependency, user edited the layout at `path`),
612-
we would re-scan for the package.
612+
Cargo would re-scan for the package.
613613
The big hurdle would be plumbing this advisory information from one lockfile, through the resolve, to the next lockfile.
614614

615615
### Include workspace license files with `cargo new`
@@ -619,7 +619,7 @@ When you run `cargo new` in a workspace,
619619
it will automatically inherit `workspace.package` fields
620620
and the `workspace.lints` table.
621621
Commonly, license files need to be copied into a package for distribution via `cargo publish`
622-
and it would help if symlinked any license files we found in the workspace root into the package
622+
and it would help if symlinked any license files Cargo found in the workspace root into the package
623623
([13328](https://github.com/rust-lang/cargo/issues/13328)).
624624

625625
On a mechanics side,

0 commit comments

Comments
 (0)