Skip to content

Commit 35775fa

Browse files
authored
fix: remove FIXME comment that's no longer a problem (#16025)
The `FIXME` comment in the tool_paths test is no longer a problem. Not only the mentioned PR is already merged, but also this comment was originally written in #10092 which is before [migration from bespoke to snapbox](#14039). Since current cargo-test-support implementation (after the migration) abstracts error messages [here](https://github.com/rust-lang/cargo/blob/e3db2dcc3e85b00529354fb15de7612ad2c446fa/crates/cargo-test-support/src/compare.rs#L260), I believe this comment is safe to be removed.
2 parents e3db2dc + e715326 commit 35775fa

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

tests/testsuite/tool_paths.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -342,9 +342,6 @@ fn custom_runner_env() {
342342
p.cargo("run")
343343
.env(&key, "nonexistent-runner --foo")
344344
.with_status(101)
345-
// FIXME: Update "Caused by" error message once rust/pull/87704 is merged.
346-
// On Windows, changing to a custom executable resolver has changed the
347-
// error messages.
348345
.with_stderr_data(str![[r#"
349346
[COMPILING] foo v0.0.1 ([ROOT]/foo)
350347
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s

0 commit comments

Comments
 (0)