Commit 39116cc
committed
Auto merge of #11851 - weihanglo:make-cargo-a-workspace, r=ehuss
Make cargo a workspace
### What does this PR try to resolve?
The first step of making cargo a workspace.
Benefits:
* Dogfooding ourselves.
* Unblock #11831: It got stuck because the new version of tempfile using `windows-sys` but some issues haven't yet be solved in rust-lang/rust.
* Make `cargo xtask` or similar developer workflow possible (e.g., #11717)
* Having our own Cargo.lock, so our CI can cover the exact binary going to ship. Also free Cargo from CI breaks due to dependency patch releases.
* Probably more? Please add them by yourself.
### How should we test and review this PR?
Please review it commit by commit. A companion PR is here rust-lang/rust#109133, and should be reviewed together.
### Unresolved issues
To limit the scope of this pull request, the following issues are intentionally left unresolved. They will be addressed right after this pull request gets merged.
- [x] Make `benches/capture` and `benches/capture` workspace members. (Addressed with 2cf9718)
- [x] Make `crates/resolver-tests` a workspace member. (Addressed with #11886)
- [ ] ~~Fix clippy warnings and re-enable clippy check in CI for all workspace members.~~
- Blocked on rust-lang/rfcs#3389 so we can more easily propagate our clippy settings
- [ ] Fix rustdoc warnings and re-enable rustdoc check in CI for all workspace members.
- [ ] Fix `linkchecker.sh` warnings in CI (#11851 (comment))
- [ ] Leverage workspace flag `--workspace` when running `cargo build` or `cargo test`, instead of using flag `-p`.
- [ ] Leverage glob syntax when probing members in `[workspace]` in Cargo.toml (i.e., `crates/*`).
### Additional information
This depends on prior works from `@Muscraft` and `@ehuss.` Credits to them!3 files changed
+3753
-35
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
| 27 | + | |
33 | 28 | | |
34 | 29 | | |
35 | 30 | | |
| |||
39 | 34 | | |
40 | 35 | | |
41 | 36 | | |
42 | | - | |
| 37 | + | |
| 38 | + | |
43 | 39 | | |
44 | 40 | | |
45 | 41 | | |
| |||
101 | 97 | | |
102 | 98 | | |
103 | 99 | | |
104 | | - | |
| 100 | + | |
105 | 101 | | |
106 | 102 | | |
107 | 103 | | |
108 | | - | |
| 104 | + | |
109 | 105 | | |
110 | 106 | | |
111 | 107 | | |
112 | 108 | | |
113 | 109 | | |
114 | 110 | | |
| 111 | + | |
| 112 | + | |
115 | 113 | | |
| 114 | + | |
116 | 115 | | |
117 | 116 | | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
| 117 | + | |
125 | 118 | | |
126 | 119 | | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
131 | 124 | | |
132 | | - | |
| 125 | + | |
133 | 126 | | |
134 | | - | |
| 127 | + | |
135 | 128 | | |
136 | 129 | | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | 130 | | |
141 | 131 | | |
142 | 132 | | |
143 | | - | |
144 | | - | |
| 133 | + | |
| 134 | + | |
145 | 135 | | |
146 | 136 | | |
147 | 137 | | |
| |||
164 | 154 | | |
165 | 155 | | |
166 | 156 | | |
167 | | - | |
| 157 | + | |
168 | 158 | | |
169 | 159 | | |
170 | 160 | | |
| |||
175 | 165 | | |
176 | 166 | | |
177 | 167 | | |
178 | | - | |
| 168 | + | |
179 | 169 | | |
180 | 170 | | |
181 | 171 | | |
| |||
192 | 182 | | |
193 | 183 | | |
194 | 184 | | |
195 | | - | |
| 185 | + | |
| 186 | + | |
196 | 187 | | |
197 | 188 | | |
198 | 189 | | |
| |||
0 commit comments