Add "Other" section after linking

Author: Kobzol

src/cargo/core/compiler/timings.js

@@ -68,6 +68,8 @@ const AXES_COLOR = getCssColor('--canvas-axes');
 const GRID_COLOR = getCssColor('--canvas-grid');
 const CODEGEN_COLOR = getCssColor('--canvas-codegen');
 const LINK_COLOR = getCssColor('--canvas-link');
+// Final leftover section after link
+const OTHER_COLOR = getCssColor('--canvas-other');
 const CUSTOM_BUILD_COLOR = getCssColor('--canvas-custom-build');
 const NOT_CUSTOM_BUILD_COLOR = getCssColor('--canvas-not-custom-build');
 const DEP_LINE_COLOR = getCssColor('--canvas-dep-line');
@@ -222,6 +224,13 @@ function render_pipeline_graph() {
       line: false
     });
   }
+  if (presentSections.has("other")) {
+    legend_entries.push({
+      name: "Other",
+      color: OTHER_COLOR,
+      line: false
+    });
+  }
   draw_legend(ctx, 160, legend_entries);
   ctx.restore();
 }
@@ -289,6 +298,8 @@ function get_section_color(name) {
         return CODEGEN_COLOR;
     } else if (name === "link") {
         return LINK_COLOR;
+    } else if (name === "other") {
+        return OTHER_COLOR;
     } else {
         // We do not know what section this is, so just use the default color
         return NOT_CUSTOM_BUILD_COLOR;

src/cargo/core/compiler/timings.rs

@@ -615,7 +615,27 @@ impl<'gctx> Timings<'gctx> {
                     .collect();
                 let aggregated = ut.aggregate_sections();
                 let sections = match aggregated {
-                    AggregatedSections::Sections(sections) => Some(sections),
+                    AggregatedSections::Sections(mut sections) => {
+                        // We draw the sections in the pipeline graph in a way where the frontend
+                        // section has the "default" build color, and then additional sections
+                        // (codegen, link) are overlayed on top with a different color.
+                        // However, there might be some time after the final (usually link) section,
+                        // which definitely shouldn't be classified as "Frontend". We thus try to
+                        // detect this situation and add a final "Other" section.
+                        if let Some((_, section)) = sections.last()
+                            && section.end < ut.duration
+                        {
+                            sections.push((
+                                "other".to_string(),
+                                SectionData {
+                                    start: section.end,
+                                    end: ut.duration,
+                                },
+                            ));
+                        }
+
+                        Some(sections)
+                    }
                     AggregatedSections::OnlyMetadataTime { .. }
                     | AggregatedSections::OnlyTotalDuration => None,
                 };
@@ -880,6 +900,7 @@ static HTML_TMPL: &str = r#"
   --canvas-grid: #e6e6e6;
   --canvas-codegen: #aa95e8;
   --canvas-link: #95e8aa;
+  --canvas-other: #e895aa;
   --canvas-custom-build: #f0b165;
   --canvas-not-custom-build: #95cce8;
   --canvas-dep-line: #ddd;