Skip to content

Commit 7b7515e

Browse files
committed
fix(build-analysis): partially reverted b43404d
Remove HTML timing output generation in favor of the upcoming JSONL logging system.
1 parent ebfa12f commit 7b7515e

File tree

2 files changed

+1
-14
lines changed

2 files changed

+1
-14
lines changed

src/cargo/core/compiler/build_config.rs

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -115,18 +115,6 @@ impl BuildConfig {
115115
(None, _) => false,
116116
};
117117

118-
let timing_outputs = match (cfg.analysis.as_ref(), gctx.cli_unstable().build_analysis) {
119-
// Enable HTML output to pretend we are persisting timing data for now.
120-
(Some(analysis), true) if analysis.enabled => vec![TimingOutput::Html],
121-
(Some(_), false) => {
122-
gctx.shell().warn(
123-
"ignoring 'build.analysis' config, pass `-Zbuild-analysis` to enable it",
124-
)?;
125-
Vec::new()
126-
}
127-
_ => Vec::new(),
128-
};
129-
130118
Ok(BuildConfig {
131119
requested_kinds,
132120
jobs,
@@ -142,7 +130,7 @@ impl BuildConfig {
142130
rustfix_diagnostic_server: Rc::new(RefCell::new(None)),
143131
export_dir: None,
144132
future_incompat_report: false,
145-
timing_outputs,
133+
timing_outputs: Vec::new(),
146134
sbom,
147135
compile_time_deps_only: false,
148136
})

tests/testsuite/build_analysis.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ fn simple() {
3737
.masquerade_as_nightly_cargo(&["build-analysis"])
3838
.with_stderr_data(str![[r#"
3939
[CHECKING] foo v0.0.0 ([ROOT]/foo)
40-
Timing report saved to [ROOT]/foo/target/cargo-timings/cargo-timing-[..].html
4140
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s
4241
4342
"#]])

0 commit comments

Comments
 (0)