refactor: IndexPackage to use Cow for package name

Signed-off-by: 0xPoe <[email protected]>

Author: 0xPoe

src/cargo/sources/registry/index/mod.rs

@@ -198,7 +198,7 @@ impl IndexSummary {
 #[derive(Deserialize, Serialize)]
 pub struct IndexPackage<'a> {
     /// Name of the package.
-    pub name: InternedString,
+    pub name: Cow<'a, str>,
     /// The version of this dependency.
     pub vers: Version,
     /// All kinds of direct dependencies of the package, including dev and
@@ -263,7 +263,11 @@ impl IndexPackage<'_> {
     fn to_summary(&self, source_id: SourceId) -> CargoResult<Summary> {
         // ****CAUTION**** Please be extremely careful with returning errors, see
         // `IndexSummary::parse` for details
-        let pkgid = PackageId::new(self.name.into(), self.vers.clone(), source_id);
+        let pkgid = PackageId::new(
+            InternedString::new(&self.name),
+            self.vers.clone(),
+            source_id,
+        );
         let deps = self
             .deps
             .iter()
@@ -288,8 +292,8 @@ impl IndexPackage<'_> {
 }
 
 #[derive(Deserialize, Serialize)]
-struct IndexPackageMinimum {
-    name: InternedString,
+struct IndexPackageMinimum<'a> {
+    name: Cow<'a, str>,
     vers: Version,
 }
 
@@ -759,7 +763,7 @@ impl IndexSummary {
             Ok((index, summary)) => (index, summary, true),
             Err(err) => {
                 let Ok(IndexPackageMinimum { name, vers }) =
-                    serde_json::from_slice::<IndexPackageMinimum>(line)
+                    serde_json::from_slice::<IndexPackageMinimum<'_>>(line)
                 else {
                     // If we can't recover, prefer the original error
                     return Err(err);