exclude_from_backups_and_indexing can't fail

Ignore errors creating the registry directory

Author: sourcefrog

crates/cargo-util/src/paths.rs

@@ -661,11 +661,12 @@ pub fn create_dir_all_excluded_from_backups_atomic(p: impl AsRef<Path>) -> Resul
 }
 
 /// Mark an existing directory as excluded from backups and indexing.
-pub fn exclude_from_backups_and_indexing(p: impl AsRef<Path>) -> Result<()> {
+///
+/// Errors in marking it are ignored.
+pub fn exclude_from_backups_and_indexing(p: impl AsRef<Path>) {
     let path = p.as_ref();
     exclude_from_backups(path);
     exclude_from_content_indexing(path);
-    Ok(())
 }
 
 /// Marks the directory as excluded from archives/backups.

src/cargo/sources/git/source.rs

@@ -135,7 +135,7 @@ impl<'cfg> Source for GitSource<'cfg> {
         // This does not use `create_dir_all_excluded_from_backups_atomic` for
         // the same reason: we want to exclude it even if the directory already
         // exists.
-        exclude_from_backups_and_indexing(&git_path)?;
+        exclude_from_backups_and_indexing(&git_path);
 
         let db_path = git_path.join("db").join(&self.ident);
 

src/cargo/sources/registry/mod.rs

@@ -822,9 +822,12 @@ impl<'cfg> Source for RegistrySource<'cfg> {
         // This does not use `create_dir_all_excluded_from_backups_atomic` for
         // the same reason: we want to exclude it even if the directory already
         // exists.
+        //
+        // IO errors in creating and marking it are ignored, e.g. in case we're on a
+        // read-only filesystem.
         let registry_base = self.config.registry_base_path();
-        registry_base.create_dir()?;
-        exclude_from_backups_and_indexing(&registry_base.into_path_unlocked())?;
+        let _ = registry_base.create_dir()?;
+        exclude_from_backups_and_indexing(&registry_base.into_path_unlocked());
 
         self.ops.block_until_ready()
     }