test: add extra test for package command

Author: ifropc

tests/testsuite/lockfile_path.rs

@@ -4,11 +4,10 @@ use std::fs;
 
 use snapbox::str;
 
-use cargo_test_support::paths::CargoPathExt;
 use cargo_test_support::registry::RegistryBuilder;
 use cargo_test_support::{
-    basic_bin_manifest, basic_lib_manifest, cargo_test, paths, project, symlink_supported, Execs,
-    Project, ProjectBuilder,
+    basic_bin_manifest, cargo_test, project, symlink_supported, Execs,
+    ProjectBuilder,
 };
 
 const VALID_LOCKFILE: &str = r#"# Test lockfile
@@ -41,7 +40,7 @@ fn make_basic_command(execs: &mut Execs, lockfile_path_argument: String) -> &mut
 }
 
 fn lockfile_must_exist(command: &str) -> bool {
-    return command == "pkgid" || command == "publish";
+    return command == "pkgid" || command == "publish" || command == "package";
 }
 
 fn assert_lockfile_created(
@@ -332,7 +331,7 @@ tests!(fetch, "fetch");
 tests!(fix, "fix", make_fix_command, make_basic_project);
 tests!(generate_lockfile, "generate-lockfile");
 tests!(metadata, "metadata");
-// tests!(package, "package"); // TODO: check why lockfile is not generated
+tests!(package, "package");
 tests!(pkgid, "pkgid");
 tests!(publish, "publish");
 tests!(remove, "remove", make_remove_command, make_remove_project);
@@ -343,3 +342,65 @@ tests!(test, "test");
 tests!(tree, "tree");
 tests!(update, "update");
 tests!(vendor, "vendor");
+
+#[cfg(test)]
+mod package_extra {
+    use std::fs;
+    use cargo_test_support::{cargo_test, project};
+    use crate::lockfile_path::{make_basic_command};
+
+    #[cargo_test(nightly, reason = "--lockfile-path is unstable")]
+    fn assert_respect_pinned_version_from_lockfile_path() {
+        const PINNED_VERSION: &str = r#"# This file is automatically @generated by Cargo.
+# It is not intended for manual editing.
+version = 3
+
+[[package]]
+name = "hello"
+version = "1.0.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "2b94f16c310ebbd9efcca5a5a17131d70bd454876f2af007f3da211afadff4fc"
+
+[[package]]
+name = "test_foo"
+version = "0.5.0"
+dependencies = [
+ "hello",
+]
+"#;
+        const TOML: &str = r#"#
+[package]
+
+name = "test_foo"
+version = "0.5.0"
+authors = ["[email protected]"]
+edition = "2015"
+
+[[bin]]
+
+name = "test_foo"
+
+[dependencies]
+hello = "1.0.0"
+"#;
+        
+        let lockfile_path_argument = "mylockfile/Cargo.lock";
+        let p = project()
+            .file("Cargo.toml", TOML)
+            .file("src/main.rs", "fn main() {}")
+            .file("mylockfile/Cargo.lock", PINNED_VERSION)
+            .build();
+        
+        make_basic_command(&mut p.cargo("package"), lockfile_path_argument.to_string()).run();
+
+        assert!(!p.root().join("Cargo.lock").is_file());
+        assert!(p.root().join(lockfile_path_argument).is_file());
+        
+        assert!(p.root().join("target/package/test_foo-0.5.0/Cargo.lock").is_file());
+        
+        let path = p.root().join("target/package/test_foo-0.5.0/Cargo.lock");
+        let contents = fs::read_to_string(path).unwrap();
+        
+        assert_eq!(contents, PINNED_VERSION);
+    }
+}