Skip to content

Commit ccd193a

Browse files
committed
refactor(fix): Centralize share manifest load/save across Editions
1 parent d4b3b9d commit ccd193a

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/cargo/ops/fix.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -268,15 +268,15 @@ fn migrate_manifests(ws: &Workspace<'_>, pkgs: &[&Package]) -> CargoResult<()> {
268268
format!("{file} from {existing_edition} edition to {prepare_for_edition}"),
269269
)?;
270270

271+
let mut manifest_mut = LocalManifest::try_new(pkg.manifest_path())?;
272+
let document = &mut manifest_mut.data;
273+
let mut fixes = 0;
274+
271275
let ws_original_toml = match ws.root_maybe() {
272276
MaybePackage::Package(package) => package.manifest().original_toml(),
273277
MaybePackage::Virtual(manifest) => manifest.original_toml(),
274278
};
275279
if Edition::Edition2024 <= prepare_for_edition {
276-
let mut manifest_mut = LocalManifest::try_new(pkg.manifest_path())?;
277-
let document = &mut manifest_mut.data;
278-
let mut fixes = 0;
279-
280280
let root = document.as_table_mut();
281281

282282
if let Some(workspace) = root
@@ -331,14 +331,14 @@ fn migrate_manifests(ws: &Workspace<'_>, pkgs: &[&Package]) -> CargoResult<()> {
331331
ws_original_toml,
332332
);
333333
}
334+
}
334335

335-
if 0 < fixes {
336-
let verb = if fixes == 1 { "fix" } else { "fixes" };
337-
let msg = format!("{file} ({fixes} {verb})");
338-
ws.gctx().shell().status("Fixed", msg)?;
336+
if 0 < fixes {
337+
let verb = if fixes == 1 { "fix" } else { "fixes" };
338+
let msg = format!("{file} ({fixes} {verb})");
339+
ws.gctx().shell().status("Fixed", msg)?;
339340

340-
manifest_mut.write()?;
341-
}
341+
manifest_mut.write()?;
342342
}
343343
}
344344

0 commit comments

Comments
 (0)