Commit da81ca3
authored
Public in private manifest errors (#16002)
### What does this PR try to resolve?
This is a stab at #13096, adding Cargo.toml context to public-in-private
errors. It intercepts public-in-private warnings from rustc and modifies
them by adding a little context.
I had a bit of difficulty with renamed crates (like, `foo_renamed = {
version = "0.1.0", package = "foo" }`). Surprisingly for me, rustc's
errors mention the original package name (foo) and not the renamed one
(foo_renamed), even though the renamed one is that one that's guaranteed
unique. This PR does its best to figure out which package is the one
being referred to, but if there's non-uniqueness involved then it just
gives up and doesn't provide context.File tree
4 files changed
+825
-45
lines changed- src/cargo
- core/compiler
- build_context
- util
- tests/testsuite
4 files changed
+825
-45
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1105 | 1105 | | |
1106 | 1106 | | |
1107 | 1107 | | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
1108 | 1112 | | |
1109 | 1113 | | |
1110 | 1114 | | |
| |||
0 commit comments