Skip to content

Commit deff0ee

Browse files
committed
fix(future): Lead with non-capital letter
Per rustc dev guide
1 parent ec9af1f commit deff0ee

File tree

2 files changed

+53
-53
lines changed

2 files changed

+53
-53
lines changed

src/cargo/core/compiler/future_incompat.rs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ pub fn save_and_display_report(
434434
let update_message = if !updated_versions.is_empty() {
435435
format!(
436436
"\
437-
Update to a newer version to see if the issue has been fixed:
437+
update to a newer version to see if the issue has been fixed
438438
{updated_versions}",
439439
updated_versions = updated_versions
440440
)
@@ -448,8 +448,8 @@ Update to a newer version to see if the issue has been fixed:
448448
let manifest = bcx.packages.get_one(*package_id).unwrap().manifest();
449449
format!(
450450
" - {package_spec}
451-
- Repository: {url}
452-
- Detailed warning command: `cargo report future-incompatibilities --id {id} --package {package_spec}`",
451+
- repository: {url}
452+
- detailed warning command: `cargo report future-incompatibilities --id {id} --package {package_spec}`",
453453
package_spec = format!("{}@{}", package_id.name(), package_id.version()),
454454
url = manifest
455455
.metadata()
@@ -466,22 +466,22 @@ Update to a newer version to see if the issue has been fixed:
466466
.iter()
467467
.all(|report| report.is_local);
468468

469-
let suggestion_header = "To solve this problem, you can try the following approaches:";
469+
let suggestion_header = "to solve this problem, you can try the following approaches:";
470470
let mut suggestions = Vec::new();
471471
if !all_is_local {
472472
if !update_message.is_empty() {
473473
suggestions.push(update_message);
474474
}
475475
suggestions.push(format!(
476476
"\
477-
Ensure the maintainers know of this problem (e.g. creating a bug report if needed)
478-
or even helping with a fix (e.g. by creating a pull request):
477+
ensure the maintainers know of this problem (e.g. creating a bug report if needed)
478+
or even helping with a fix (e.g. by creating a pull request)
479479
480480
{upstream_info}"
481481
));
482482
suggestions.push(
483483
"\
484-
Use your own version of the dependency with the `[patch]` section in `Cargo.toml`.
484+
use your own version of the dependency with the `[patch]` section in `Cargo.toml`
485485
For more information, see:
486486
https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section"
487487
.to_owned(),

tests/testsuite/future_incompat_report.rs

Lines changed: 46 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -146,16 +146,16 @@ fn incompat_in_dependency() {
146146
.with_stderr_data(str![[r#"
147147
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s
148148
[WARNING] the following packages contain code that will be rejected by a future version of Rust: bar v1.0.0
149-
[NOTE] To solve this problem, you can try the following approaches:
149+
[NOTE] to solve this problem, you can try the following approaches:
150150
151-
- Ensure the maintainers know of this problem (e.g. creating a bug report if needed)
152-
or even helping with a fix (e.g. by creating a pull request):
151+
- ensure the maintainers know of this problem (e.g. creating a bug report if needed)
152+
or even helping with a fix (e.g. by creating a pull request)
153153
154154
155-
- Repository: https://example.com/
156-
- Detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
155+
- repository: https://example.com/
156+
- detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
157157
158-
- Use your own version of the dependency with the `[patch]` section in `Cargo.toml`.
158+
- use your own version of the dependency with the `[patch]` section in `Cargo.toml`
159159
For more information, see:
160160
https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section
161161
@@ -176,16 +176,16 @@ to be in wide use.
176176
Each warning should contain a link for more information on what the warning
177177
means and how to resolve it.
178178
179-
To solve this problem, you can try the following approaches:
179+
to solve this problem, you can try the following approaches:
180180
181-
- Ensure the maintainers know of this problem (e.g. creating a bug report if needed)
182-
or even helping with a fix (e.g. by creating a pull request):
181+
- ensure the maintainers know of this problem (e.g. creating a bug report if needed)
182+
or even helping with a fix (e.g. by creating a pull request)
183183
184184
185-
- Repository: https://example.com/
186-
- Detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
185+
- repository: https://example.com/
186+
- detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
187187
188-
- Use your own version of the dependency with the `[patch]` section in `Cargo.toml`.
188+
- use your own version of the dependency with the `[patch]` section in `Cargo.toml`
189189
For more information, see:
190190
https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section
191191
@@ -595,29 +595,29 @@ fn suggestions_for_updates() {
595595
[CHECKING] foo v0.1.0 ([ROOT]/foo)
596596
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s
597597
[WARNING] the following packages contain code that will be rejected by a future version of Rust: big_update v1.0.0, with_updates v1.0.0, without_updates v1.0.0
598-
[NOTE] To solve this problem, you can try the following approaches:
598+
[NOTE] to solve this problem, you can try the following approaches:
599599
600-
- Update to a newer version to see if the issue has been fixed:
600+
- update to a newer version to see if the issue has been fixed
601601
602602
- big_update v1.0.0 has the following newer versions available: 2.0.0
603603
- with_updates v1.0.0 has the following newer versions available: 1.0.1, 1.0.2, 3.0.1
604604
605-
- Ensure the maintainers know of this problem (e.g. creating a bug report if needed)
606-
or even helping with a fix (e.g. by creating a pull request):
605+
- ensure the maintainers know of this problem (e.g. creating a bug report if needed)
606+
or even helping with a fix (e.g. by creating a pull request)
607607
608608
609-
- Repository: <not found>
610-
- Detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
609+
- repository: <not found>
610+
- detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
611611
612612
613-
- Repository: <not found>
614-
- Detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
613+
- repository: <not found>
614+
- detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
615615
616616
617-
- Repository: <not found>
618-
- Detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
617+
- repository: <not found>
618+
- detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
619619
620-
- Use your own version of the dependency with the `[patch]` section in `Cargo.toml`.
620+
- use your own version of the dependency with the `[patch]` section in `Cargo.toml`
621621
For more information, see:
622622
https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section
623623
@@ -638,29 +638,29 @@ to be in wide use.
638638
Each warning should contain a link for more information on what the warning
639639
means and how to resolve it.
640640
641-
To solve this problem, you can try the following approaches:
641+
to solve this problem, you can try the following approaches:
642642
643-
- Update to a newer version to see if the issue has been fixed:
643+
- update to a newer version to see if the issue has been fixed
644644
645645
- big_update v1.0.0 has the following newer versions available: 2.0.0
646646
- with_updates v1.0.0 has the following newer versions available: 1.0.1, 1.0.2, 3.0.1
647647
648-
- Ensure the maintainers know of this problem (e.g. creating a bug report if needed)
649-
or even helping with a fix (e.g. by creating a pull request):
648+
- ensure the maintainers know of this problem (e.g. creating a bug report if needed)
649+
or even helping with a fix (e.g. by creating a pull request)
650650
651651
652-
- Repository: <not found>
653-
- Detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
652+
- repository: <not found>
653+
- detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
654654
655655
656-
- Repository: <not found>
657-
- Detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
656+
- repository: <not found>
657+
- detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
658658
659659
660-
- Repository: <not found>
661-
- Detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
660+
- repository: <not found>
661+
- detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
662662
663-
- Use your own version of the dependency with the `[patch]` section in `Cargo.toml`.
663+
- use your own version of the dependency with the `[patch]` section in `Cargo.toml`
664664
For more information, see:
665665
https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section
666666
@@ -700,16 +700,16 @@ fn correct_report_id_when_cached() {
700700
[CHECKING] foo v1.0.0 ([ROOT]/foo)
701701
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s
702702
[WARNING] the following packages contain code that will be rejected by a future version of Rust: bar v1.0.0
703-
[NOTE] To solve this problem, you can try the following approaches:
703+
[NOTE] to solve this problem, you can try the following approaches:
704704
705-
- Ensure the maintainers know of this problem (e.g. creating a bug report if needed)
706-
or even helping with a fix (e.g. by creating a pull request):
705+
- ensure the maintainers know of this problem (e.g. creating a bug report if needed)
706+
or even helping with a fix (e.g. by creating a pull request)
707707
708708
709-
- Repository: https://example.com/
710-
- Detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
709+
- repository: https://example.com/
710+
- detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
711711
712-
- Use your own version of the dependency with the `[patch]` section in `Cargo.toml`.
712+
- use your own version of the dependency with the `[patch]` section in `Cargo.toml`
713713
For more information, see:
714714
https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section
715715
@@ -723,16 +723,16 @@ https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch
723723
.with_stderr_data(str![[r#"
724724
[FINISHED] `dev` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s
725725
[WARNING] the following packages contain code that will be rejected by a future version of Rust: bar v1.0.0
726-
[NOTE] To solve this problem, you can try the following approaches:
726+
[NOTE] to solve this problem, you can try the following approaches:
727727
728-
- Ensure the maintainers know of this problem (e.g. creating a bug report if needed)
729-
or even helping with a fix (e.g. by creating a pull request):
728+
- ensure the maintainers know of this problem (e.g. creating a bug report if needed)
729+
or even helping with a fix (e.g. by creating a pull request)
730730
731731
732-
- Repository: https://example.com/
733-
- Detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
732+
- repository: https://example.com/
733+
- detailed warning command: `cargo report future-incompatibilities --id 1 --package [email protected]`
734734
735-
- Use your own version of the dependency with the `[patch]` section in `Cargo.toml`.
735+
- use your own version of the dependency with the `[patch]` section in `Cargo.toml`
736736
For more information, see:
737737
https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html#the-patch-section
738738

0 commit comments

Comments
 (0)