refactor: Change RegistryDependency to use Cow for name, featrues and

package

Signed-off-by: 0xPoe <[email protected]>

Author: 0xPoe

src/cargo/sources/registry/index/mod.rs

@@ -319,13 +319,13 @@ struct IndexPackageV {
 pub struct RegistryDependency<'a> {
     /// Name of the dependency. If the dependency is renamed, the original
     /// would be stored in [`RegistryDependency::package`].
-    pub name: InternedString,
+    pub name: Cow<'a, str>,
     /// The SemVer requirement for this dependency.
     #[serde(borrow)]
     pub req: Cow<'a, str>,
     /// Set of features enabled for this dependency.
     #[serde(default)]
-    pub features: Vec<InternedString>,
+    pub features: Vec<Cow<'a, str>>,
     /// Whether or not this is an optional dependency.
     #[serde(default)]
     pub optional: bool,
@@ -340,7 +340,7 @@ pub struct RegistryDependency<'a> {
     // `None` if it is from the same index.
     pub registry: Option<Cow<'a, str>>,
     /// The original name if the dependency is renamed.
-    pub package: Option<InternedString>,
+    pub package: Option<Cow<'a, str>>,
     /// Whether or not this is a public dependency. Unstable. See [RFC 1977].
     ///
     /// [RFC 1977]: https://rust-lang.github.io/rfcs/1977-public-private-dependencies.html
@@ -844,7 +844,11 @@ impl<'a> RegistryDependency<'a> {
             default
         };
 
-        let mut dep = Dependency::parse(package.unwrap_or(name), Some(&req), id)?;
+        let name = package
+            .as_ref()
+            .map(|p| InternedString::new(&p))
+            .unwrap_or(InternedString::new(&name));
+        let mut dep = Dependency::parse(name, Some(&req), id)?;
         if package.is_some() {
             dep.set_explicit_name_in_toml(name);
         }
@@ -880,6 +884,10 @@ impl<'a> RegistryDependency<'a> {
             dep.set_artifact(artifact);
         }
 
+        let features = features
+            .iter()
+            .map(|f| InternedString::new(&f))
+            .collect::<Vec<_>>();
         dep.set_optional(optional)
             .set_default_features(default_features)
             .set_features(features)