Add `text-direction-codepoint-in-comment` lint

[epage]

See https://doc.rust-lang.org/rustc/lints/listing/deny-by-default.html?highlight=unicode#text-direction-codepoint-in-comment

[enthropy7]

could i take both PR's?

[weihanglo]

could i take both PR's?

What did you mean by both?

Note that this is labelled S-needs-mentor so the expectation of efforts is higher and needs a maintainer to commit to help review.

[enthropy7]

#16373 same type tasks. yes, i noted of course, not scared of hard/not simple tasks

[weihanglo]

The effort of these tasks is not only about implementation, but the design and the requirement, as well as aligning with the future development of the -Zcargo-lints system infra. You might want to discuss before diving into coding.

I am not epage so I am not sure what he expected when opening these ticket. Perhaps it is about integration of rustc lints, or it is for linting Cargo.toml. I don't know.

[epage]

This is for reimplementing the rustc lint for Cargo.toml, likely easiest by scanning the raw String for those code points.

This came from a discussion of whether rustc or cargo should lint frontmatter.

[enthropy7]

The effort of these tasks is not only about implementation, but the design and the requirement, as well as aligning with the future development of the -Zcargo-lints system infra. You might want to discuss before diving into coding.

I am not epage so I am not sure what he expected when opening these ticket. Perhaps it is about integration of rustc lints, or it is for linting Cargo.toml. I don't know.

reasonable, i think author meaned that cargo should match actual rustc-lint from the link he attached to message. i thought it's about editing schema in manifest (affect's cargo toml) to match the expected behavior.

[enthropy7]

This is for reimplementing the rustc lint for Cargo.toml, likely easiest by scanning the raw String for those code points.

This came from a discussion of whether rustc or cargo should lint frontmatter.

oh, thanks

[enthropy7]

Got it, thanks for clarifying. I can work on implementing a manifest lint under -Zcargo-lints, that scans the raw Cargo.toml source for the same Unicode directionality control code points as rustc’s text-direction-codepoint-in-comment/literal. Does that align with your intent?

[enthropy7]

@rustbot claim