Skip to content

add ICON from crates.io to the cargo executable on windows #16056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

add ICON from crates.io to the cargo executable on windows #16056

wants to merge 1 commit into from
+41 −4

Conversation

ShadowDara
Copy link

Thanks for the pull request 🎉!
Please read the contribution guide: https://doc.crates.io/contrib/.

What does this PR try to resolve?

The Change add a software icon to the cargo executable on windows

How to test and review this PR?

The Code changes the standard Icon from windows to the Icon from crates.io

@rustbot rustbot added A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 6, 2025

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

weihanglo
weihanglo reviewed Oct 6, 2025
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the code contribution.

Per our contributing guide, we encourage to discuss first before jumping straight to a pull request.

If you're willing to, please open a new issue for discussions. I'll mark this as draft for now.

@weihanglo weihanglo marked this pull request as draft October 6, 2025 18:23
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2025
@ShadowDara
Copy link
Author

Okay i am sorry, i though this just a little change so ... I'm sorry

@ShadowDara
Copy link
Author

Issue as Feature Request or Inspiring Idea? I'll Inspiring Idea for now, because its not really a Feature

@ShadowDara
Copy link
Author

For Anyone Reading this, here: https://internals.rust-lang.org/t/add-icon-from-crates-io-to-the-cargo-executable-on-windows/23597

@joshtriplett
Copy link
Member

Some preliminary feedback (leaving aside for the moment the question of whether we want to do this): this should be conditional on the target being windows, not the build architecture being windows, so that you get the icon even when cross-compiling to windows. Look at windows_manifest() for the way the conditionals are structured.

@mathstuf
Copy link
Contributor

mathstuf commented Oct 7, 2025

Additionally, what is the license of the icon? (I know I can follow the link in the code, but I feel like it needs to be more explicit here.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@weihanglo weihanglo

Labels
A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ShadowDara @rustbot @joshtriplett @mathstuf @weihanglo