Skip to content

Commit 1d6f8cf

Browse files
authored
Don't set definition flags for MSVC ARM targets (#518)
* Don't set definition flags for MSVC ARM targets * Warn on -D flags for MSVC ARM assemblers
1 parent fbc1214 commit 1d6f8cf

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

src/lib.rs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1690,11 +1690,15 @@ impl Build {
16901690
for directory in self.include_directories.iter() {
16911691
cmd.arg("-I").arg(directory);
16921692
}
1693-
for &(ref key, ref value) in self.definitions.iter() {
1694-
if let Some(ref value) = *value {
1695-
cmd.arg(&format!("-D{}={}", key, value));
1696-
} else {
1697-
cmd.arg(&format!("-D{}", key));
1693+
if target.contains("aarch64") || target.contains("arm") {
1694+
println!("cargo:warning=The MSVC ARM assemblers do not support -D flags");
1695+
} else {
1696+
for &(ref key, ref value) in self.definitions.iter() {
1697+
if let Some(ref value) = *value {
1698+
cmd.arg(&format!("-D{}={}", key, value));
1699+
} else {
1700+
cmd.arg(&format!("-D{}", key));
1701+
}
16981702
}
16991703
}
17001704

0 commit comments

Comments
 (0)