Do not set the -fPIC flag for Windows targets when using clang for CXX builds (#481)

datalus · web-flow · commit a885236506a1 · 2020-03-03T09:57:11.000-06:00
diff --git a/src/lib.rs b/src/lib.rs
@@ -1374,7 +1374,7 @@ impl Build {
                 // Disable generation of PIC on bare-metal for now: rust-lld doesn't support this yet
                 if self
                     .pic
-                    .unwrap_or(!target.contains("windows-gnu") && !target.contains("-none-"))
+                    .unwrap_or(!target.contains("windows") && !target.contains("-none-"))
                 {
                     cmd.push_cc_arg("-fPIC".into());
                     // PLT only applies if code is compiled with PIC support,

Original file line number	Diff line number	Diff line change
`@@ -1374,7 +1374,7 @@ impl Build {`
`1374`	`1374`	`// Disable generation of PIC on bare-metal for now: rust-lld doesn't support this yet`
`1375`	`1375`	`if self`
`1376`	`1376`	`.pic`
`1377`		`- .unwrap_or(!target.contains("windows-gnu") && !target.contains("-none-"))`
	`1377`	`+ .unwrap_or(!target.contains("windows") && !target.contains("-none-"))`
`1378`	`1378`	`{`
`1379`	`1379`	`cmd.push_cc_arg("-fPIC".into());`
`1380`	`1380`	`// PLT only applies if code is compiled with PIC support,`