Return ambiguous solution on !should_continue

detrumi · detrumi · commit 05e6f4310918 · 2022-11-29T13:20:30.000+01:00
diff --git a/chalk-recursive/src/solve.rs b/chalk-recursive/src/solve.rs
@@ -44,7 +44,7 @@ pub(super) trait SolveIteration<I: Interner>: SolveDatabase<I> {
         should_continue: impl std::ops::Fn() -> bool + Clone,
     ) -> Fallible<Solution<I>> {
         if !should_continue() {
-            return Err(NoSolution);
+            return Ok(Solution::Ambig(Guidance::Unknown));
         }
 
         let UCanonical {

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ pub(super) trait SolveIteration<I: Interner>: SolveDatabase<I> {`
`44`	`44`	`should_continue: impl std::ops::Fn() -> bool + Clone,`
`45`	`45`	`) -> Fallible<Solution<I>> {`
`46`	`46`	`if !should_continue() {`
`47`		`- return Err(NoSolution);`
	`47`	`+ return Ok(Solution::Ambig(Guidance::Unknown));`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`let UCanonical {`