Fix clippy::redundant_clone

Author: Kinrany

chalk-engine/src/logic.rs

@@ -1483,7 +1483,7 @@ impl<'forest, I: Interner> SolveState<'forest, I> {
             .collect();
 
         let subst = Canonical {
-            binders: binders.clone(),
+            binders: binders,
             value: AnswerSubst {
                 subst,
                 constraints: Constraints::from_iter(self.context.program().interner(), constraints),

chalk-engine/src/strand.rs

@@ -45,7 +45,7 @@ impl<I: Interner> Fold<I> for Strand<I> {
         Ok(Strand {
             ex_clause: self.ex_clause.fold_with(folder, outer_binder)?,
             last_pursued_time: self.last_pursued_time,
-            selected_subgoal: self.selected_subgoal.clone(),
+            selected_subgoal: self.selected_subgoal,
         })
     }
 }

chalk-ir/src/fold.rs

@@ -182,7 +182,7 @@ pub trait Folder<I: Interner> {
         } else {
             let bound_var = bound_var.shifted_in_from(outer_binder);
             Ok(ConstData {
-                ty: ty.clone().fold_with(self.as_dyn(), outer_binder)?,
+                ty: ty.fold_with(self.as_dyn(), outer_binder)?,
                 value: ConstValue::<I>::BoundVar(bound_var),
             }
             .intern(self.interner()))

chalk-recursive/src/fixed_point.rs

@@ -125,7 +125,7 @@ where
         if let Some(cache) = &self.cache {
             if let Some(value) = cache.get(goal) {
                 debug!("solve_reduced_goal: cache hit, value={:?}", value);
-                return value.clone();
+                return value;
             }
         }
 

chalk-solve/src/clauses.rs

@@ -1025,7 +1025,7 @@ fn match_ty<I: Interner>(
         TyKind::Closure(_, _) | TyKind::Generator(_, _) | TyKind::GeneratorWitness(_, _) => {
             let ty = generalize::Generalize::apply(builder.db.interner(), ty.clone());
             builder.push_binders(ty, |builder, ty| {
-                builder.push_fact(WellFormed::Ty(ty.clone()));
+                builder.push_fact(WellFormed::Ty(ty));
             });
         }
         TyKind::Placeholder(_) => {
@@ -1041,9 +1041,7 @@ fn match_ty<I: Interner>(
             .to_program_clauses(builder, environment),
         TyKind::Function(_quantified_ty) => {
             let ty = generalize::Generalize::apply(builder.db.interner(), ty.clone());
-            builder.push_binders(ty, |builder, ty| {
-                builder.push_fact(WellFormed::Ty(ty.clone()))
-            });
+            builder.push_binders(ty, |builder, ty| builder.push_fact(WellFormed::Ty(ty)));
         }
         TyKind::BoundVar(_) => return Err(Floundered),
         TyKind::Dyn(dyn_ty) => {
@@ -1062,7 +1060,6 @@ fn match_ty<I: Interner>(
             builder.push_binders(generalized_ty, |builder, dyn_ty| {
                 let bounds = dyn_ty
                     .bounds
-                    .clone()
                     .substitute(interner, &[ty.clone().cast::<GenericArg<I>>(interner)]);
 
                 let mut wf_goals = Vec::new();

chalk-solve/src/clauses/builtin_traits/copy.rs

@@ -43,7 +43,7 @@ pub fn add_copy_program_clauses<I: Interner>(
             push_tuple_copy_conditions(db, builder, trait_ref, arity, substitution)
         }
         TyKind::Array(ty, _) => {
-            needs_impl_for_tys(db, builder, trait_ref, iter::once(ty.clone()));
+            needs_impl_for_tys(db, builder, trait_ref, iter::once(ty));
         }
         TyKind::FnDef(_, _) => {
             builder.push_fact(trait_ref);

chalk-solve/src/infer/canonicalize.rs

@@ -136,7 +136,7 @@ impl<'i, I: Interner> Folder<I> for Canonicalizer<'i, I> {
     ) -> Fallible<Const<I>> {
         let interner = self.interner;
         self.max_universe = max(self.max_universe, universe.ui);
-        Ok(universe.to_const(interner, ty.clone()))
+        Ok(universe.to_const(interner, ty))
     }
 
     fn forbid_free_vars(&self) -> bool {

chalk-solve/src/infer/ucanonicalize.rs

@@ -289,7 +289,7 @@ impl<'i, I: Interner> Folder<I> for UMapToCanonical<'i, I> {
             ui: universe,
             idx: universe0.idx,
         }
-        .to_const(self.interner(), ty.clone()))
+        .to_const(self.interner(), ty))
     }
 
     fn interner(&self) -> I {

chalk-solve/src/infer/unify.rs

@@ -1290,7 +1290,7 @@ impl<'i, I: Interner> Folder<I> for OccursCheck<'_, 'i, I> {
         if self.universe_index < universe.ui {
             Err(NoSolution)
         } else {
-            Ok(universe.to_const(interner, ty.clone())) // no need to shift, not relative to depth
+            Ok(universe.to_const(interner, ty)) // no need to shift, not relative to depth
         }
     }