Merge pull request #68 from davidtwco/finish-out-of-tree-crates-policy

Finish out-of-tree crates policy.

Author: nikomatsakis

procedures/crates.md

@@ -94,6 +94,13 @@ request.
 Recommendations for working with out-of-tree crates will be documented in the rustc-guide, see
 [rust-lang/rustc-guide#285][guide_issue] for progress.
 
+### How should stabilization/semantic changes be handled in out-of-tree crates?
+It is important to involve the language team in any changes in out-of-tree crates that would result
+in stabilization or semantic changes to the language. Submodule changes in PRs to `rust-lang/rust`
+should be labelled appropriately (eg. `relnotes`, `T-compiler`, `T-lang`) just as if the change
+were implemented in `rust-lang/rust` directly, include a description of the changes when it is not
+obvious to those unfamiliar with the compiler or the out-of-tree crate.
+
 [licenses]: https://github.com/rust-lang/rust/blob/master/src/tools/tidy/src/deps.rs#L10-L19
 [guide_issue]: https://github.com/rust-lang/rustc-guide/issues/285
 
@@ -103,28 +110,43 @@ In summary, the process for establishing an out-of-tree crate is as follows:
 
 1. Where appropriate, discuss and confirm the need within the working group for the out-of-tree
    crate.
-2. Create a PR modifying this document to include the crate in the list below. Use
+1. Create a PR modifying this document to include the crate in the list below. Use
    [`@rfcbot merge`](https://github.com/anp/rfcbot-rs#usage) to gain agreement from compiler
    team members.
-3. Create a new repository in the `rust-lang` organization (permissions should be available for all
-   compiler team members).
-4. Add a README describing the intended purpose of the crate, which team and working group are
-   responsible (link to their page in this repository) and the intended level of maintenance and
-   stability.
-
-   > This crate is developed and maintained by the [Rust compiler team](..) for use within
-   > `rustc`, in particular, it is the responsibility of the
-   > [`.template`](../working-groups/.template) working group. This crate [will have regular
-   > breaking changes and provides no stability guarantees|is intended to remain stable and have
-   > limited breaking changes].
-5. Include the [LICENSE-APACHE][apache] and [LICENSE-MIT][mit] files from `rust-lang/rust`.
-6. Include or link the [CODE_OF_CONDUCT][coc] file from `rust-lang/rust`.
-7. Consult with the infrastructure team to set up `@bors` and `@rust-highfive` and a process for
+1. Create a new repository in the `rust-lang` organization.
+    1. Navigate to `Settings > Collaborators & Teams` and add the `Compiler` team with write
+       privileges and `Assignees` with `read`.
+        - Individuals that are not part of the team can be added where appropriate.
+    1. Add a README describing the intended purpose of the crate, which team and working group are
+       responsible (link to their page in this repository) and the intended level of maintenance and
+       stability.
+
+       > This crate is developed and maintained by the [Rust compiler team](..) for use within
+       > `rustc`, in particular, it is the responsibility of the
+       > [`.template`](../working-groups/.template) working group. This crate [will have regular
+       > breaking changes and provides no stability guarantees|is intended to remain stable and have
+       > limited breaking changes].
+    1. Include the [LICENSE-APACHE][apache] and [LICENSE-MIT][mit] files from `rust-lang/rust`.
+    1. Include or link the [CODE_OF_CONDUCT][coc] file from `rust-lang/rust`.
+    1. Create a relevant `.gitignore` ([here's a sane default][gitignore]).
+    1. Create `P-high`, `P-med`, `P-low`, `I-nominated` and `T-compiler` labels.
+1. Consult with the infrastructure team to set up `@rust-highfive` and a process for
    publishing under the "The Rust Project Developers" crates.io account.
-8. Perform any initial development required before integration with rustc.
-9. Publish initial version, following semantic versioning.
-10. Add the crate as a dependency to the appropriate in-tree crate and start using.
-
+     1. Add a basic `.travis.yml`:
+
+     ```yaml
+     language: rust
+     rust:
+     - stable
+     ```
+     - `@bors` is not normally used for out-of-tree crates, GitHub's built-in merge facilities can
+       be used instead.
+1. Perform any initial development required before integration with rustc.
+1. Publish initial version, following semantic versioning.
+1. Add the crate as a dependency to the appropriate in-tree crate and start using.
+
+[gitignore]: https://gitignore.io/api/vim,rust,emacs,clion,visualstudio,visualstudiocode
+[triagebot]: https://github.com/rust-lang/rust/blob/master/triagebot.toml
 [apache]: https://github.com/rust-lang/rust/blob/master/LICENSE-APACHE
 [coc]: https://github.com/rust-lang/rust/blob/master/CODE_OF_CONDUCT.md
 [mit]: https://github.com/rust-lang/rust/blob/master/LICENSE-MIT
@@ -143,5 +165,6 @@ The same policies apply to all compiler-team-maintained crates used in the compi
 ## List of out-of-tree crates
 This section contains the list of existing out-of-tree, compiler team-maintained crates:
 
-  - [`rust-lang-nursery/chalk`](https://github.com/rust-lang-nursery/chalk/)
-  - [`rust-lang-nursery/polonius`](https://github.com/rust-lang-nursery/polonius/)
+  - [`rust-lang/chalk`](https://github.com/rust-lang/chalk/)
+  - [`rust-lang/polonius`](https://github.com/rust-lang/polonius/)
+  - [`rust-lang/measureme`](https://github.com/rust-lang/measureme/)