Fix clippy lints

Author: Mark-Simulacrum

src/crates/lists.rs

@@ -88,7 +88,7 @@ pub(crate) fn get_crates(
             all_crates.append(&mut GitHubList::get(db)?);
             all_crates.append(&mut LocalList::get(db)?);
 
-            for krate in all_crates.drain(..) {
+            for krate in all_crates {
                 let add = match krate {
                     Crate::Registry(RegistryCrate { ref name, .. }) => demo_registry.remove(name),
                     Crate::GitHub(ref repo) => demo_github.remove(&repo.slug()),

src/runner/graph.rs

@@ -155,11 +155,11 @@ impl TasksGraph {
 
         // Try to check for the dependencies of this node
         // The list is collected to make the borrowchecker happy
-        let mut neighbors = self.graph.neighbors(node).collect::<Vec<_>>();
+        let neighbors = self.graph.neighbors(node).collect::<Vec<_>>();
         log::trace!("{} | {:?}: neighbors: {:?}", worker, node, neighbors);
 
         let mut blocked = false;
-        for neighbor in neighbors.drain(..) {
+        for neighbor in neighbors {
             match self.walk_graph(neighbor, ex, db, worker) {
                 WalkResult::Task(id, task) => return WalkResult::Task(id, task),
                 WalkResult::Finished => return WalkResult::Finished,
@@ -219,12 +219,12 @@ impl TasksGraph {
         result: &TestResult,
         worker: &str,
     ) -> Fallible<()> {
-        let mut children = self
+        let children = self
             .graph
             .neighbors_directed(node, Direction::Incoming)
             .collect::<Vec<_>>();
         let mut last_err = None;
-        for child in children.drain(..) {
+        for child in children {
             // Don't recursively mark a child as failed if this is not the only parent of the child
             let parents = self
                 .graph

src/runner/mod.rs

@@ -157,7 +157,7 @@ pub fn run_ex<DB: WriteResults + Sync>(
                     Ok(())
                 })?;
 
-        let clean_exit = join_threads(threads.drain(..));
+        let clean_exit = join_threads(threads.into_iter());
         disk_watcher.stop();
         let disk_watcher_clean_exit = join_threads(std::iter::once(disk_watcher_thread));