Fix clippy warnings

Author: wesleywiser

src/agent/mod.rs

@@ -51,7 +51,7 @@ impl Capabilities {
     pub fn for_agent(db: &Database, agent: &str) -> Fallible<Self> {
         let caps = db.query(
             "SELECT capability FROM agent_capabilities WHERE agent_name = ?1",
-            &[&agent],
+            [&agent],
             |r| r.get::<_, String>(0),
         )?;
 
@@ -153,7 +153,7 @@ fn run_experiment(
     db: &ResultsUploader,
     threads_count: usize,
     past_experiment: &mut Option<String>,
-) -> Result<(), (Option<Experiment>, Error)> {
+) -> Result<(), (Option<Box<Experiment>>, Error)> {
     let ex = agent.experiment().map_err(|e| (None, e))?;
 
     if Some(&ex.name) != past_experiment.as_ref() {
@@ -177,7 +177,7 @@ fn run_experiment(
     crate::runner::run_ex(&ex, workspace, db, threads_count, &agent.config, &|| {
         agent.next_crate(&ex.name)
     })
-    .map_err(|err| (Some(ex), err))?;
+    .map_err(|err| (Some(Box::new(ex)), err))?;
     Ok(())
 }
 

src/crates/lists.rs

@@ -48,7 +48,7 @@ pub(crate) trait List {
     fn get(db: &Database) -> Fallible<Vec<Crate>> {
         let crates_results = db.query(
             "SELECT crate FROM crates WHERE list = ?1 ORDER BY rowid;",
-            &[&Self::NAME],
+            [&Self::NAME],
             |r| r.get::<_, String>(0),
         )?;
 

src/db/migrations.rs

@@ -408,7 +408,7 @@ pub fn execute(db: &mut Connection) -> Fallible<()> {
             }
             .with_context(|_| format!("error running migration: {}", name))?;
 
-            t.execute("INSERT INTO migrations (name) VALUES (?1)", &[&name])?;
+            t.execute("INSERT INTO migrations (name) VALUES (?1)", [&name])?;
             t.commit()?;
 
             info!("executed migration: {}", name);

src/experiments.rs

@@ -268,7 +268,7 @@ impl Experiment {
     pub fn unfinished(db: &Database) -> Fallible<Vec<Experiment>> {
         let records = db.query(
             "SELECT * FROM experiments WHERE status != ?1 ORDER BY priority DESC, created_at;",
-            &[&Status::Completed.to_str()],
+            [&Status::Completed.to_str()],
             |r| ExperimentDBRecord::from_row(r),
         )?;
         records
@@ -283,7 +283,7 @@ impl Experiment {
                 select latest_work_for from agents where ('agent:' || agents.name) = ?1
             ) and status = ?2 \
             limit 1",
-            &[&assignee.to_string(), Status::Running.to_str()],
+            [&assignee.to_string(), Status::Running.to_str()],
             |r| ExperimentDBRecord::from_row(r),
         )?;
 
@@ -483,7 +483,7 @@ impl Experiment {
     pub fn get(db: &Database, name: &str) -> Fallible<Option<Experiment>> {
         let record = db.get_row(
             "SELECT * FROM experiments WHERE name = ?1;",
-            &[&name],
+            [&name],
             |r| ExperimentDBRecord::from_row(r),
         )?;
 
@@ -552,7 +552,7 @@ impl Experiment {
         let results_len: u32 = db
             .get_row(
                 "SELECT COUNT(*) AS count FROM results WHERE experiment = ?1;",
-                &[&self.name.as_str()],
+                [&self.name.as_str()],
                 |r| r.get("count"),
             )?
             .unwrap();
@@ -561,7 +561,7 @@ impl Experiment {
             .get_row(
                 "SELECT COUNT(*) AS count FROM experiment_crates \
                  WHERE experiment = ?1 AND skipped = 0;",
-                &[&self.name.as_str()],
+                [&self.name.as_str()],
                 |r| r.get("count"),
             )?
             .unwrap();
@@ -573,7 +573,7 @@ impl Experiment {
         let results: Vec<(String, u32)> = db.query(
             "SELECT result, COUNT(*) FROM results \
              WHERE experiment = ?1 GROUP BY result;",
-            &[&self.name.as_str()],
+            [&self.name.as_str()],
             |r| Ok((r.get::<_, String>(0)?, r.get(1)?)),
         )?;
 
@@ -596,7 +596,7 @@ impl Experiment {
     pub fn get_crates(&self, db: &Database) -> Fallible<Vec<Crate>> {
         db.query(
             "SELECT crate FROM experiment_crates WHERE experiment = ?1;",
-            &[&self.name],
+            [&self.name],
             |r| r.get(0),
         )?
         .into_iter()

src/main.rs

@@ -50,7 +50,7 @@ fn main() {
             "command failed"
         }
     );
-    process::exit(if success { 0 } else { 1 });
+    process::exit(i32::from(!success));
 }
 
 fn main_() -> Fallible<()> {

src/results/db.rs

@@ -150,7 +150,7 @@ impl<'a> ReadResults for DatabaseDB<'a> {
             "SELECT log, encoding FROM results \
              WHERE experiment = ?1 AND toolchain = ?2 AND crate = ?3 \
              LIMIT 1;",
-            &[&ex.name, &toolchain.to_string(), &krate.id()],
+            [&ex.name, &toolchain.to_string(), &krate.id()],
             |row| {
                 let log: Vec<u8> = row.get("log")?;
                 let encoding: String = row.get("encoding")?;
@@ -176,7 +176,7 @@ impl<'a> ReadResults for DatabaseDB<'a> {
                 "SELECT result FROM results \
                  WHERE experiment = ?1 AND toolchain = ?2 AND crate = ?3 \
                  LIMIT 1;",
-                &[&ex.name, &toolchain.to_string(), &krate.id()],
+                [&ex.name, &toolchain.to_string(), &krate.id()],
                 |row| row.get("result"),
             )?
             .pop();

src/server/routes/webhooks/commands.rs

@@ -311,7 +311,7 @@ fn store_experiment_name(db: &Database, issue: &Issue, name: &str) -> Fallible<(
 fn default_experiment_name(db: &Database, issue: &Issue) -> Fallible<Option<String>> {
     let name = db.get_row(
         "SELECT experiment FROM saved_names WHERE issue = ?1",
-        &[&issue.number],
+        [&issue.number],
         |r| r.get(0),
     )?;
 

src/server/try_builds.rs

@@ -51,7 +51,7 @@ pub(crate) fn detect(
 pub(crate) fn get_sha(db: &Database, repo: &str, pr: i32) -> Fallible<Option<TryBuild>> {
     db.get_row(
         "SELECT base_sha, merge_sha FROM try_builds WHERE repo = ?1 AND pr = ?2;",
-        &[repo, &pr.to_string()],
+        [repo, &pr.to_string()],
         |row| {
             Ok(TryBuild {
                 base_sha: row.get("base_sha")?,