Auto merge of #622 - Mark-Simulacrum:prune, r=Mark-Simulacrum

Remove dump-tasks-graph

This isn't being used and will likely hurt the ability to refactor the task
graph away from being an actual graph.

Author: bors

src/cli.rs

@@ -306,17 +306,6 @@ pub enum Crater {
         no_default_capabilities: bool,
     },
 
-    #[structopt(
-        name = "dump-tasks-graph",
-        about = "dump the internal tasks graph in .dot format"
-    )]
-    DumpTasksGraph {
-        #[structopt(name = "dest", parse(from_os_str))]
-        dest: PathBuf,
-        #[structopt(name = "experiment", long = "ex", default_value = "default")]
-        ex: Ex,
-    },
-
     #[structopt(
         name = "check-config",
         about = "check if the config.toml file is valid"
@@ -628,16 +617,6 @@ impl Crater {
                         .workspace(docker_env.as_ref().map(|s| s.as_str()), fast_workspace_init)?,
                 )?;
             }
-            Crater::DumpTasksGraph { ref dest, ref ex } => {
-                let config = Config::load()?;
-                let db = Database::open()?;
-
-                if let Some(experiment) = Experiment::get(&db, &ex.0)? {
-                    runner::dump_dot(&experiment, &experiment.get_crates(&db)?, &config, dest)?;
-                } else {
-                    bail!("missing experiment: {}", ex.0);
-                }
-            }
             Crater::CheckConfig { ref filename } => {
                 if let Err(ref e) = Config::check(filename) {
                     bail!("check-config failed: {}", e);

src/runner/graph.rs

@@ -25,7 +25,7 @@ use crate::runner::{
     tasks::{Task, TaskStep},
     RunnerState,
 };
-use petgraph::{dot::Dot, graph::NodeIndex, stable_graph::StableDiGraph, Direction};
+use petgraph::{graph::NodeIndex, stable_graph::StableDiGraph, Direction};
 use std::fmt::{self, Debug};
 use std::sync::Arc;
 
@@ -263,10 +263,6 @@ impl TasksGraph {
     pub(super) fn pending_crates_count(&self) -> usize {
         self.graph.neighbors(self.root).count()
     }
-
-    pub(super) fn generate_dot<'a>(&'a self) -> Dot<&'a StableDiGraph<impl Debug, ()>> {
-        Dot::new(&self.graph)
-    }
 }
 
 pub(super) fn build_graph(ex: &Experiment, crates: &[Crate], config: &Config) -> TasksGraph {

src/runner/mod.rs

@@ -15,7 +15,6 @@ use crossbeam_utils::thread::{scope, ScopedJoinHandle};
 use rustwide::logging::LogStorage;
 use rustwide::Workspace;
 use std::collections::HashMap;
-use std::path::Path;
 use std::sync::{Condvar, Mutex};
 use std::time::Duration;
 
@@ -196,15 +195,3 @@ where
     }
     clean_exit
 }
-
-pub fn dump_dot(ex: &Experiment, crates: &[Crate], config: &Config, dest: &Path) -> Fallible<()> {
-    info!("computing the tasks graph...");
-    let graph = build_graph(ex, crates, config);
-
-    info!("dumping the tasks graph...");
-    ::std::fs::write(dest, format!("{:?}", graph.generate_dot()).as_bytes())?;
-
-    info!("tasks graph available in {}", dest.to_string_lossy());
-
-    Ok(())
-}