Fix clippy lints

Author: GuillaumeGomez

src/db/migrations.rs

@@ -164,17 +164,11 @@ fn migrations() -> Vec<(&'static str, MigrationKind)> {
 
             t.execute("PRAGMA foreign_keys = OFF;", [])?;
             t.execute(
-                &format!(
-                    "UPDATE experiments SET toolchain_start = {}(toolchain_start);",
-                    fn_name
-                ),
+                &format!("UPDATE experiments SET toolchain_start = {fn_name}(toolchain_start);",),
                 [],
             )?;
             t.execute(
-                &format!(
-                    "UPDATE experiments SET toolchain_end = {}(toolchain_end);",
-                    fn_name
-                ),
+                &format!("UPDATE experiments SET toolchain_end = {fn_name}(toolchain_end);",),
                 [],
             )?;
             t.execute(

src/experiments.rs

@@ -622,9 +622,8 @@ impl Experiment {
                         "SELECT crate FROM experiment_crates WHERE experiment = ?1
                             AND skipped = 0
                             AND status = 'queued'
-                            AND (started_at is null or started_at <= datetime('now', '-{} minutes'))
+                            AND (started_at is null or started_at <= datetime('now', '-{RUN_TIMEOUT} minutes'))
                         LIMIT ?2;",
-                        RUN_TIMEOUT
                     ),
                     rusqlite::params![self.name, limit],
                     |r| r.get("crate"),

src/runner/worker.rs

@@ -77,7 +77,7 @@ impl<'a, DB: WriteResults + Sync> Worker<'a, DB> {
             };
 
             for err in e.iter_chain() {
-                if let Some(&OverrideResult(ref res)) = err.downcast_ctx() {
+                if let Some(OverrideResult(res)) = err.downcast_ctx() {
                     result = res.clone();
                     break;
                 }

src/server/auth.rs

@@ -135,7 +135,7 @@ impl ACL {
         }
 
         let mut orgs = HashMap::new();
-        for &(ref org, ref team) in &self.teams {
+        for (org, team) in &self.teams {
             if let Err(err) = self.load_team(github, &mut new_cache, &mut orgs, org, team) {
                 warn!(
                     "failed to authorize members of {}/{} to use the bot",

src/server/routes/webhooks/commands.rs

@@ -105,8 +105,7 @@ pub fn run(
                     message = message.line(
                         "warning",
                         format!(
-                            "Try build based on commit {}, but latest commit is {}. Did you forget to make a new try build?",
-                            old_pr_head, pr_head
+                            "Try build based on commit {old_pr_head}, but latest commit is {pr_head}. Did you forget to make a new try build?",
                         ),
                     );
                 }