Skip to content

Commit 04b4c29

Browse files
committed
tests/routes/crates/list: Simplify new_user() test helper call
There is no need for an "upsert" operation here since we know that the database is in a clean state in our tests. Additionally, this drops the need for the `Emails` implementation, since all we want is a user in the database, but without any email address confirmation emails being sent out.
1 parent e8bd2ef commit 04b4c29

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/tests/routes/crates/list.rs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use crate::models::Category;
2-
use crate::schema::crates;
2+
use crate::schema::{crates, users};
33
use crate::tests::builders::{CrateBuilder, VersionBuilder};
44
use crate::tests::util::{RequestHelper, TestApp};
55
use crate::tests::{new_category, new_user};
@@ -21,11 +21,13 @@ async fn index() {
2121
assert_eq!(json.meta.total, 0);
2222
}
2323

24-
let u = new_user("foo")
25-
.create_or_update(None, &app.as_inner().emails, &mut conn)
24+
let user_id = insert_into(users::table)
25+
.values(new_user("foo"))
26+
.returning(users::id)
27+
.get_result(&mut conn)
2628
.unwrap();
2729

28-
let krate = CrateBuilder::new("fooindex", u.id).expect_build(&mut conn);
30+
let krate = CrateBuilder::new("fooindex", user_id).expect_build(&mut conn);
2931

3032
for json in search_both(&anon, "").await {
3133
assert_eq!(json.crates.len(), 1);

0 commit comments

Comments
 (0)