Skip to content

Commit 051bf15

Browse files
committed
fix very brittle selector tests
1 parent b35e3f3 commit 051bf15

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

e2e/acceptance/crate.spec.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ test.describe('Acceptance | crate page', { tag: '@acceptance' }, () => {
131131
await page.click('[data-test-versions-tab] a');
132132

133133
await expect(page.locator('[data-test-page-description]')).toHaveText(
134-
/13 of 13\s+nanomsg versions since\s+December \d+th, 2014/,
134+
/\s+13\s+of\s+13\s+nanomsg\s+versions since\s+December \d+th, 2014/,
135135
);
136136
});
137137

@@ -140,12 +140,12 @@ test.describe('Acceptance | crate page', { tag: '@acceptance' }, () => {
140140

141141
await page.goto('/crates/nanomsg/versions?per_page=10');
142142
await expect(page.locator('[data-test-page-description]')).toHaveText(
143-
/10 of 13\s+nanomsg versions since\s+December \d+th, 2014/,
143+
/\s+10\s+of\s+13\s+nanomsg\s+versions since\s+December \d+th, 2014/,
144144
);
145145

146146
await page.getByTestId('load-more').click();
147147
await expect(page.locator('[data-test-page-description]')).toHaveText(
148-
/13 of 13\s+nanomsg versions since\s+December \d+th, 2014/,
148+
/\s+13\s+of\s+13\s+nanomsg\s+versions since\s+December \d+th, 2014/,
149149
);
150150
});
151151

tests/acceptance/crate-test.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,18 +137,24 @@ module('Acceptance | crate page', function (hooks) {
137137
await visit('/crates/nanomsg');
138138
await click('[data-test-versions-tab] a');
139139

140-
assert.dom('[data-test-page-description]').hasText(/13 of 13\s+nanomsg versions since\s+December \d+th, 2014/);
140+
assert
141+
.dom('[data-test-page-description]')
142+
.hasText(/\s+13\s+of\s+13\s+nanomsg\s+versions since\s+December \d+th, 2014/);
141143
});
142144

143145
test('navigating to the versions page with custom per_page', async function (assert) {
144146
loadFixtures(this.db);
145147

146148
await visit('/crates/nanomsg/versions?per_page=10');
147149

148-
assert.dom('[data-test-page-description]').hasText(/10 of 13\s+nanomsg versions since\s+December \d+th, 2014/);
150+
assert
151+
.dom('[data-test-page-description]')
152+
.hasText(/\s+10\s+of\s+13\s+nanomsg\s+versions since\s+December \d+th, 2014/);
149153

150154
await click('[data-test-id="load-more"]');
151-
assert.dom('[data-test-page-description]').hasText(/13 of 13\s+nanomsg versions since\s+December \d+th, 2014/);
155+
assert
156+
.dom('[data-test-page-description]')
157+
.hasText(/\s+13\s+of\s+13\s+nanomsg\s+versions since\s+December \d+th, 2014/);
152158
});
153159

154160
test('navigating to the reverse dependencies page', async function (assert) {

0 commit comments

Comments
 (0)