msw: Implement PUT /api/v1/crates/:name/owners request handler

Author: Turbo87

packages/crates-io-msw/handlers/crates.js

@@ -1,3 +1,4 @@
+import addOwners from './crates/add-owners.js';
 import deleteCrate from './crates/delete.js';
 import downloads from './crates/downloads.js';
 import followCrate from './crates/follow.js';
@@ -16,6 +17,7 @@ export default [
   following,
   followCrate,
   unfollowCrate,
+  addOwners,
   userOwners,
   teamOwners,
   reverseDependencies,

packages/crates-io-msw/handlers/crates/add-owners.js

@@ -0,0 +1,54 @@
+import { http, HttpResponse } from 'msw';
+
+import { db } from '../../index.js';
+import { notFound } from '../../utils/handlers.js';
+import { getSession } from '../../utils/session.js';
+
+export default http.put('/api/v1/crates/:name/owners', async ({ request, params }) => {
+  let { user } = getSession();
+  if (!user) {
+    return HttpResponse.json({ errors: [{ detail: 'must be logged in to perform that action' }] }, { status: 403 });
+  }
+
+  let crate = db.crate.findFirst({ where: { name: { equals: params.name } } });
+  if (!crate) {
+    return notFound();
+  }
+
+  let body = await request.json();
+
+  let users = [];
+  let teams = [];
+  let msgs = [];
+  for (let login of body.owners) {
+    if (login.includes(':')) {
+      let team = db.team.findFirst({ where: { login: { equals: login } } });
+      if (!team) {
+        let errorMessage = `could not find team with login \`${login}\``;
+        return HttpResponse.json({ errors: [{ detail: errorMessage }] }, { status: 404 });
+      }
+
+      teams.push(team);
+      msgs.push(`team ${login} has been added as an owner of crate ${crate.name}`);
+    } else {
+      let user = db.user.findFirst({ where: { login: { equals: login } } });
+      if (!user) {
+        let errorMessage = `could not find user with login \`${login}\``;
+        return HttpResponse.json({ errors: [{ detail: errorMessage }] }, { status: 404 });
+      }
+
+      users.push(user);
+      msgs.push(`user ${login} has been invited to be an owner of crate ${crate.name}`);
+    }
+  }
+
+  for (let team of teams) {
+    db.crateOwnership.create({ crate, team });
+  }
+
+  for (let invitee of users) {
+    db.crateOwnerInvitation.create({ crate, inviter: user, invitee });
+  }
+
+  return HttpResponse.json({ ok: true, msg: msgs.join(',') });
+});

packages/crates-io-msw/handlers/crates/add-owners.test.js

@@ -0,0 +1,111 @@
+import { assert, test } from 'vitest';
+
+import { db } from '../../index.js';
+
+const ADD_USER_BODY = JSON.stringify({ owners: ['john-doe'] });
+
+test('returns 403 if unauthenticated', async function () {
+  let response = await fetch('/api/v1/crates/foo/owners', { method: 'PUT', body: ADD_USER_BODY });
+  assert.strictEqual(response.status, 403);
+  assert.deepEqual(await response.json(), {
+    errors: [{ detail: 'must be logged in to perform that action' }],
+  });
+});
+
+test('returns 404 for unknown crates', async function () {
+  let user = db.user.create();
+  db.mswSession.create({ user });
+
+  let response = await fetch('/api/v1/crates/foo/owners', { method: 'PUT', body: ADD_USER_BODY });
+  assert.strictEqual(response.status, 404);
+  assert.deepEqual(await response.json(), { errors: [{ detail: 'Not Found' }] });
+});
+
+test('can add new owner', async function () {
+  let user = db.user.create();
+  db.mswSession.create({ user });
+
+  let crate = db.crate.create({ name: 'foo' });
+  db.crateOwnership.create({ crate, user });
+
+  let user2 = db.user.create();
+
+  let body = JSON.stringify({ owners: [user2.login] });
+  let response = await fetch('/api/v1/crates/foo/owners', { method: 'PUT', body });
+  assert.strictEqual(response.status, 200);
+  assert.deepEqual(await response.json(), {
+    ok: true,
+    msg: 'user user-2 has been invited to be an owner of crate foo',
+  });
+
+  let owners = db.crateOwnership.findMany({ where: { crate: { id: { equals: crate.id } } } });
+  assert.strictEqual(owners.length, 1);
+  assert.strictEqual(owners[0].user.id, user.id);
+
+  let invites = db.crateOwnerInvitation.findMany({ where: { crate: { id: { equals: crate.id } } } });
+  assert.strictEqual(invites.length, 1);
+  assert.strictEqual(invites[0].inviter.id, user.id);
+  assert.strictEqual(invites[0].invitee.id, user2.id);
+});
+
+test('can add team owner', async function () {
+  let user = db.user.create();
+  db.mswSession.create({ user });
+
+  let crate = db.crate.create({ name: 'foo' });
+  db.crateOwnership.create({ crate, user });
+
+  let team = db.team.create();
+
+  let body = JSON.stringify({ owners: [team.login] });
+  let response = await fetch('/api/v1/crates/foo/owners', { method: 'PUT', body });
+  assert.strictEqual(response.status, 200);
+  assert.deepEqual(await response.json(), {
+    ok: true,
+    msg: 'team github:rust-lang:team-1 has been added as an owner of crate foo',
+  });
+
+  let owners = db.crateOwnership.findMany({ where: { crate: { id: { equals: crate.id } } } });
+  assert.strictEqual(owners.length, 2);
+  assert.strictEqual(owners[0].user.id, user.id);
+  assert.strictEqual(owners[0].team, null);
+  assert.strictEqual(owners[1].user, null);
+  assert.strictEqual(owners[1].team.id, user.id);
+
+  let invites = db.crateOwnerInvitation.findMany({ where: { crate: { id: { equals: crate.id } } } });
+  assert.strictEqual(invites.length, 0);
+});
+
+test('can add multiple owners', async function () {
+  let user = db.user.create();
+  db.mswSession.create({ user });
+
+  let crate = db.crate.create({ name: 'foo' });
+  db.crateOwnership.create({ crate, user });
+
+  let team = db.team.create();
+  let user2 = db.user.create();
+  let user3 = db.user.create();
+
+  let body = JSON.stringify({ owners: [user2.login, team.login, user3.login] });
+  let response = await fetch('/api/v1/crates/foo/owners', { method: 'PUT', body });
+  assert.strictEqual(response.status, 200);
+  assert.deepEqual(await response.json(), {
+    ok: true,
+    msg: 'user user-2 has been invited to be an owner of crate foo,team github:rust-lang:team-1 has been added as an owner of crate foo,user user-3 has been invited to be an owner of crate foo',
+  });
+
+  let owners = db.crateOwnership.findMany({ where: { crate: { id: { equals: crate.id } } } });
+  assert.strictEqual(owners.length, 2);
+  assert.strictEqual(owners[0].user.id, user.id);
+  assert.strictEqual(owners[0].team, null);
+  assert.strictEqual(owners[1].user, null);
+  assert.strictEqual(owners[1].team.id, user.id);
+
+  let invites = db.crateOwnerInvitation.findMany({ where: { crate: { id: { equals: crate.id } } } });
+  assert.strictEqual(invites.length, 2);
+  assert.strictEqual(invites[0].inviter.id, user.id);
+  assert.strictEqual(invites[0].invitee.id, user2.id);
+  assert.strictEqual(invites[1].inviter.id, user.id);
+  assert.strictEqual(invites[1].invitee.id, user3.id);
+});