Skip to content

Commit 0ef8d1c

Browse files
authored
Simplify nested imports (#10250)
1 parent a30dac5 commit 0ef8d1c

File tree

15 files changed

+50
-92
lines changed

15 files changed

+50
-92
lines changed

src/bin/crates-admin/render_readmes.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
use anyhow::{anyhow, Context};
2-
use crates_io::{
3-
db,
4-
models::Version,
5-
schema::{crates, readme_renderings, versions},
6-
};
2+
use crates_io::db;
3+
use crates_io::models::Version;
4+
use crates_io::schema::{crates, readme_renderings, versions};
75
use futures_util::{StreamExt, TryStreamExt};
86
use std::path::{Path, PathBuf};
97
use std::{future, sync::Arc};

src/bin/crates-admin/transfer_crates.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
use crate::dialoguer;
2-
use crates_io::{
3-
db,
4-
models::{Crate, OwnerKind, User},
5-
schema::{crate_owners, crates, users},
6-
};
2+
use crates_io::db;
3+
use crates_io::models::{Crate, OwnerKind, User};
4+
use crates_io::schema::{crate_owners, crates, users};
75

86
use diesel::prelude::*;
97
use diesel_async::{AsyncPgConnection, RunQueryDsl};

src/tests/builders/krate.rs

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,8 @@
1-
use crate::{
2-
models::{Category, Crate, Keyword, NewCrate},
3-
schema::{crates, version_downloads},
4-
util::errors::AppResult,
5-
};
1+
use crate::models::{update_default_version, Category, Crate, Keyword, NewCrate};
2+
use crate::schema::{crate_downloads, crates, version_downloads};
3+
use crate::util::errors::AppResult;
64

75
use super::VersionBuilder;
8-
use crate::models::update_default_version;
9-
use crate::schema::crate_downloads;
106
use chrono::NaiveDateTime;
117
use diesel::prelude::*;
128
use diesel_async::{AsyncPgConnection, RunQueryDsl};

src/tests/builders/version.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
1-
use crate::{
2-
models::{Crate, NewVersion, Version},
3-
schema::dependencies,
4-
util::errors::AppResult,
5-
};
1+
use crate::models::{Crate, NewVersion, Version};
2+
use crate::schema::dependencies;
3+
use crate::util::errors::AppResult;
64
use std::collections::BTreeMap;
75

86
use chrono::NaiveDateTime;

src/tests/mod.rs

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1+
use crate::models::{Crate, CrateOwner, NewCategory, NewTeam, NewUser, OwnerKind, Team, User};
2+
use crate::schema::crate_owners;
13
use crate::tests::util::{RequestHelper, TestApp};
2-
use crate::{
3-
models::{Crate, CrateOwner, NewCategory, NewTeam, NewUser, OwnerKind, Team, User},
4-
schema::crate_owners,
5-
views::{
6-
EncodableCategory, EncodableCategoryWithSubcategories, EncodableCrate, EncodableKeyword,
7-
EncodableOwner, EncodableVersion, GoodCrate,
8-
},
4+
use crate::views::{
5+
EncodableCategory, EncodableCategoryWithSubcategories, EncodableCrate, EncodableKeyword,
6+
EncodableOwner, EncodableVersion, GoodCrate,
97
};
108

119
use crate::tests::util::github::next_gh_id;

src/tests/owners.rs

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,11 @@
1-
use crate::tests::{
2-
add_team_to_crate,
3-
builders::{CrateBuilder, PublishBuilder},
4-
new_team,
5-
util::{MockAnonymousUser, MockCookieUser, MockTokenUser, RequestHelper, Response},
6-
TestApp,
1+
use crate::models::Crate;
2+
use crate::tests::builders::{CrateBuilder, PublishBuilder};
3+
use crate::tests::util::{
4+
MockAnonymousUser, MockCookieUser, MockTokenUser, RequestHelper, Response,
75
};
8-
use crate::{
9-
models::Crate,
10-
views::{
11-
EncodableCrateOwnerInvitationV1, EncodableOwner, EncodablePublicUser, InvitationResponse,
12-
},
6+
use crate::tests::{add_team_to_crate, new_team, TestApp};
7+
use crate::views::{
8+
EncodableCrateOwnerInvitationV1, EncodableOwner, EncodablePublicUser, InvitationResponse,
139
};
1410

1511
use crate::schema::users;

src/tests/team.rs

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
1-
use crate::tests::{
2-
add_team_to_crate,
3-
builders::{CrateBuilder, PublishBuilder},
4-
new_team, OwnerTeamsResponse, RequestHelper, TestApp,
5-
};
6-
use crate::{
7-
models::{Crate, NewTeam},
8-
schema::teams,
9-
};
1+
use crate::models::{Crate, NewTeam};
2+
use crate::schema::teams;
3+
use crate::tests::builders::{CrateBuilder, PublishBuilder};
4+
use crate::tests::{add_team_to_crate, new_team, OwnerTeamsResponse, RequestHelper, TestApp};
105

116
use diesel::*;
127
use diesel_async::RunQueryDsl;

src/tests/user.rs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
use crate::models::{ApiToken, Email, NewUser, User};
2-
use crate::tests::{
3-
new_user,
4-
util::{MockCookieUser, RequestHelper},
5-
TestApp,
6-
};
2+
use crate::tests::util::{MockCookieUser, RequestHelper};
3+
use crate::tests::{new_user, TestApp};
74
use crate::util::token::HashedToken;
85
use diesel::prelude::*;
96
use diesel_async::RunQueryDsl;

src/tests/util/chaosproxy.rs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,10 @@
11
use anyhow::{anyhow, Context};
22
use std::net::SocketAddr;
33
use std::sync::Arc;
4-
use tokio::{
5-
io::{AsyncReadExt, AsyncWriteExt},
6-
net::{
7-
tcp::{OwnedReadHalf, OwnedWriteHalf},
8-
TcpListener, TcpStream,
9-
},
10-
sync::broadcast::Sender,
11-
};
4+
use tokio::io::{AsyncReadExt, AsyncWriteExt};
5+
use tokio::net::tcp::{OwnedReadHalf, OwnedWriteHalf};
6+
use tokio::net::{TcpListener, TcpStream};
7+
use tokio::sync::broadcast::Sender;
128
use tracing::{debug, error};
139
use url::Url;
1410

src/tests/util/matchers.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
1-
use googletest::{
2-
description::Description,
3-
matcher::{Matcher, MatcherBase, MatcherResult},
4-
};
1+
use googletest::description::Description;
2+
use googletest::matcher::{Matcher, MatcherBase, MatcherResult};
53
use http::StatusCode;
64

75
pub fn is_success() -> SuccessMatcher {

0 commit comments

Comments
 (0)