tests/util/test_app: Convert empty() fn to async

Author: Turbo87

src/tests/authentication.rs

@@ -9,7 +9,7 @@ static URL: &str = "/api/v1/me/updates";
 
 #[tokio::test(flavor = "multi_thread")]
 async fn anonymous_user_unauthorized() {
-    let (_, anon) = TestApp::init().empty();
+    let (_, anon) = TestApp::init().empty().await;
     let response: Response<()> = anon.get(URL).await;
 
     assert_eq!(response.status(), StatusCode::FORBIDDEN);
@@ -18,7 +18,7 @@ async fn anonymous_user_unauthorized() {
 
 #[tokio::test(flavor = "multi_thread")]
 async fn token_auth_cannot_find_token() {
-    let (_, anon) = TestApp::init().empty();
+    let (_, anon) = TestApp::init().empty().await;
     let mut request = anon.request_builder(Method::GET, URL);
     request.header(header::AUTHORIZATION, "cio1tkfake-token");
     let response: Response<()> = anon.run(request).await;
@@ -32,7 +32,7 @@ async fn token_auth_cannot_find_token() {
 // the database, it is not possible to implement this same test for a token.
 #[tokio::test(flavor = "multi_thread")]
 async fn cookie_auth_cannot_find_user() {
-    let (app, anon) = TestApp::init().empty();
+    let (app, anon) = TestApp::init().empty().await;
 
     let session_key = app.as_inner().session_key();
     let cookie = encode_session_header(session_key, -1);

src/tests/github_secret_scanning.rs

@@ -211,7 +211,7 @@ async fn github_secret_alert_for_unknown_token() {
 
 #[tokio::test(flavor = "multi_thread")]
 async fn github_secret_alert_invalid_signature_fails() {
-    let (_, anon) = TestApp::init().with_github(github_mock()).empty();
+    let (_, anon) = TestApp::init().with_github(github_mock()).empty().await;
 
     // No headers or request body
     let request = anon.post_request(URL);

src/tests/issues/issue2736.rs

@@ -9,7 +9,7 @@ use insta::assert_snapshot;
 /// See <https://github.com/rust-lang/crates.io/issues/2736>.
 #[tokio::test(flavor = "multi_thread")]
 async fn test_issue_2736() -> anyhow::Result<()> {
-    let (app, _) = TestApp::full().empty();
+    let (app, _) = TestApp::full().empty().await;
     let mut conn = app.db_conn();
 
     // - A user had a GitHub account named, let's say, `foo`

src/tests/middleware/head.rs

@@ -3,7 +3,7 @@ use http::{Method, StatusCode};
 
 #[tokio::test(flavor = "multi_thread")]
 async fn head_method_works() {
-    let (_, anon) = TestApp::init().empty();
+    let (_, anon) = TestApp::init().empty().await;
 
     let req = anon.request_builder(Method::HEAD, "/api/v1/summary");
     let res = anon.run::<()>(req).await;
@@ -13,7 +13,7 @@ async fn head_method_works() {
 
 #[tokio::test(flavor = "multi_thread")]
 async fn head_method_works_for_404() {
-    let (_, anon) = TestApp::init().empty();
+    let (_, anon) = TestApp::init().empty().await;
 
     let req = anon.request_builder(Method::HEAD, "/unknown");
     let res = anon.run::<()>(req).await;

src/tests/not_found_error.rs

@@ -4,7 +4,7 @@ use insta::assert_snapshot;
 
 #[tokio::test(flavor = "multi_thread")]
 async fn visiting_unknown_route_returns_404() {
-    let (_, anon) = TestApp::init().empty();
+    let (_, anon) = TestApp::init().empty().await;
 
     let response = anon.get::<()>("/does-not-exist").await;
     assert_eq!(response.status(), StatusCode::NOT_FOUND);
@@ -13,7 +13,7 @@ async fn visiting_unknown_route_returns_404() {
 
 #[tokio::test(flavor = "multi_thread")]
 async fn visiting_unknown_api_route_returns_404() {
-    let (_, anon) = TestApp::init().empty();
+    let (_, anon) = TestApp::init().empty().await;
 
     let response = anon.get::<()>("/api/v1/does-not-exist").await;
     assert_eq!(response.status(), StatusCode::NOT_FOUND);

src/tests/read_only_mode.rs

@@ -11,7 +11,8 @@ async fn can_hit_read_only_endpoints_in_read_only_mode() {
         .with_config(|config| {
             config.db.primary.read_only_mode = true;
         })
-        .empty();
+        .empty()
+        .await;
 
     let response = anon.get::<()>("/api/v1/crates").await;
     assert_eq!(response.status(), StatusCode::OK);

src/tests/routes/categories/get.rs

@@ -9,7 +9,7 @@ use serde_json::Value;
 
 #[tokio::test(flavor = "multi_thread")]
 async fn show() {
-    let (app, anon) = TestApp::init().empty();
+    let (app, anon) = TestApp::init().empty().await;
     let mut conn = app.db_conn();
 
     let url = "/api/v1/categories/foo-bar";

src/tests/routes/categories/list.rs

@@ -8,7 +8,7 @@ use serde_json::Value;
 
 #[tokio::test(flavor = "multi_thread")]
 async fn index() {
-    let (app, anon) = TestApp::init().empty();
+    let (app, anon) = TestApp::init().empty().await;
     let mut conn = app.async_db_conn().await;
 
     // List 0 categories if none exist

src/tests/routes/category_slugs/list.rs

@@ -8,7 +8,7 @@ use serde_json::Value;
 
 #[tokio::test(flavor = "multi_thread")]
 async fn category_slugs_returns_all_slugs_in_alphabetical_order() {
-    let (app, anon) = TestApp::init().empty();
+    let (app, anon) = TestApp::init().empty().await;
     let mut conn = app.async_db_conn().await;
 
     let cats = vec![

src/tests/routes/crates/list.rs

@@ -13,7 +13,7 @@ use std::sync::LazyLock;
 
 #[tokio::test(flavor = "multi_thread")]
 async fn index() {
-    let (app, anon) = TestApp::init().empty();
+    let (app, anon) = TestApp::init().empty().await;
     let mut conn = app.db_conn();
 
     for json in search_both(&anon, "").await {