e2e/crate/settings: Move Percy snapshot to fix snapshot flakiness (#11486)

In some cases the snapshot was showing an empty page because while the URL had already changed, the content hadn't yet been rendered. By moving the snapshot after the assertions we can ensure that the page content has rendered by the time we take the snapshot.

Author: Turbo87

e2e/routes/crate/settings.spec.ts

@@ -83,8 +83,6 @@ test.describe('Route | crate.settings', { tag: '@routes' }, () => {
       await page.goto('/crates/foo/settings');
       await expect(page).toHaveURL('/crates/foo/settings');
 
-      await percy.snapshot();
-
       await expect(page.locator('[data-test-trusted-publishing]')).toBeVisible();
       await expect(page.locator('[data-test-add-trusted-publisher-button]')).toBeVisible();
       await expect(page.locator('[data-test-github-config]')).toHaveCount(2);
@@ -102,6 +100,8 @@ test.describe('Route | crate.settings', { tag: '@routes' }, () => {
       await expect(page.locator('[data-test-github-config="2"] [data-test-remove-config-button]')).toBeVisible();
       await expect(page.locator('[data-test-no-config]')).not.toBeVisible();
 
+      await percy.snapshot();
+
       // Click the remove button
       await page.click('[data-test-github-config="2"] [data-test-remove-config-button]');