mirage: Fix README status codes

We are serving these files via S3, which unfortunately returns 403 instead of 404 for missing files...

Author: Turbo87

mirage/route-handlers/crates.js

@@ -374,12 +374,12 @@ export function register(server) {
     const { name, version: versionNum } = request.params;
     const crate = schema.crates.findBy({ name });
     if (!crate) {
-      return new Response(404, { 'Content-Type': 'text/html' }, '');
+      return new Response(403, { 'Content-Type': 'text/html' }, '');
     }
 
     const version = schema.versions.findBy({ crateId: crate.id, num: versionNum });
     if (!version || !version.readme) {
-      return new Response(404, { 'Content-Type': 'text/html' }, '');
+      return new Response(403, { 'Content-Type': 'text/html' }, '');
     }
 
     return new Response(200, { 'Content-Type': 'text/html' }, version.readme);

tests/mirage/crates/versions/readme-test.js

@@ -11,15 +11,15 @@ module('Mirage | GET /api/v1/crates/:id/:version/readme', function (hooks) {
 
   test('returns 404 for unknown crates', async function (assert) {
     let response = await fetch('/api/v1/crates/foo/1.0.0/readme');
-    assert.strictEqual(response.status, 404);
+    assert.strictEqual(response.status, 403);
     assert.strictEqual(await response.text(), '');
   });
 
   test('returns 404 for unknown versions', async function (assert) {
     this.server.create('crate', { name: 'rand' });
 
     let response = await fetch('/api/v1/crates/rand/1.0.0/readme');
-    assert.strictEqual(response.status, 404);
+    assert.strictEqual(response.status, 403);
     assert.strictEqual(await response.text(), '');
   });
 
@@ -28,7 +28,7 @@ module('Mirage | GET /api/v1/crates/:id/:version/readme', function (hooks) {
     this.server.create('version', { crate, num: '1.0.0' });
 
     let response = await fetch('/api/v1/crates/rand/1.0.0/readme');
-    assert.strictEqual(response.status, 404);
+    assert.strictEqual(response.status, 403);
     assert.strictEqual(await response.text(), '');
   });