controllers/version/downloads: Extract DownloadsQueryParams struct

Author: Turbo87

Cargo.toml

@@ -125,7 +125,7 @@ tracing-subscriber = { version = "=0.3.19", features = ["env-filter", "json"] }
 typomania = { version = "=0.1.2", default-features = false }
 url = "=2.5.4"
 unicode-xid = "=0.2.6"
-utoipa = "=5.2.0"
+utoipa = { version = "=5.2.0", features = ["chrono"] }
 utoipa-axum = "=0.1.2"
 
 [dev-dependencies]

src/controllers/version/downloads.rs

@@ -9,6 +9,7 @@ use crate::schema::*;
 use crate::util::errors::AppResult;
 use crate::util::{redirect, RequestUtils};
 use crate::views::EncodableVersionDownload;
+use axum::extract::{FromRequestParts, Query};
 use axum::response::{IntoResponse, Response};
 use axum_extra::json;
 use axum_extra::response::ErasedJson;
@@ -41,29 +42,37 @@ pub async fn download_version(
     }
 }
 
+#[derive(Debug, Deserialize, FromRequestParts, utoipa::IntoParams)]
+#[from_request(via(Query))]
+#[into_params(parameter_in = Query)]
+pub struct DownloadsQueryParams {
+    /// Only return download counts before this date.
+    #[param(example = "2024-06-28")]
+    before_date: Option<NaiveDate>,
+}
+
 /// Get the download counts for a crate version.
 ///
 /// This includes the per-day downloads for the last 90 days.
 #[utoipa::path(
     get,
     path = "/api/v1/crates/{name}/{version}/downloads",
-    params(CrateVersionPath),
+    params(CrateVersionPath, DownloadsQueryParams),
     tag = "versions",
     responses((status = 200, description = "Successful Response")),
 )]
 pub async fn get_version_downloads(
     app: AppState,
     path: CrateVersionPath,
-    req: Parts,
+    params: DownloadsQueryParams,
 ) -> AppResult<ErasedJson> {
     let mut conn = app.db_read().await?;
     let version = path.load_version(&mut conn).await?;
 
-    let cutoff_end_date = req
-        .query()
-        .get("before_date")
-        .and_then(|d| NaiveDate::parse_from_str(d, "%F").ok())
+    let cutoff_end_date = params
+        .before_date
         .unwrap_or_else(|| Utc::now().date_naive());
+
     let cutoff_start_date = cutoff_end_date - Duration::days(89);
 
     let downloads = VersionDownload::belonging_to(&version)

src/snapshots/crates_io__openapi__tests__openapi_snapshot.snap

@@ -1044,6 +1044,20 @@ snapshot_kind: text
             "schema": {
               "type": "string"
             }
+          },
+          {
+            "description": "Only return download counts before this date.",
+            "example": "2024-06-28",
+            "in": "query",
+            "name": "before_date",
+            "required": false,
+            "schema": {
+              "format": "date",
+              "type": [
+                "string",
+                "null"
+              ]
+            }
           }
         ],
         "responses": {