Skip to content

Commit 1cd1b6f

Browse files
committed
models/crate: Rename versionsObj getter with loadedVersionsById
1 parent bebfe95 commit 1cd1b6f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

app/controllers/crate/versions.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export default class SearchController extends Controller {
1414
}
1515

1616
get sortedVersions() {
17-
let { versionIdsBySemver, versionIdsByDate, versionsObj: versions } = this.crate;
17+
let { versionIdsBySemver, versionIdsByDate, loadedVersionsById: versions } = this.crate;
1818

1919
return (this.sort === 'semver' ? versionIdsBySemver : versionIdsByDate).map(id => versions.get(id));
2020
}

app/models/crate.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,22 +38,22 @@ export default class Crate extends Model {
3838
@hasMany('dependency', { async: true, inverse: null }) reverse_dependencies;
3939

4040
@cached get versionIdsBySemver() {
41-
let versions = this.versionsObj.values();
41+
let versions = this.loadedVersionsById.values();
4242
return Array.from(versions)
4343
.sort(compareVersionBySemver)
4444
.map(v => v.id);
4545
}
4646

4747
@cached get versionIdsByDate() {
48-
let versions = this.versionsObj.values();
48+
let versions = this.loadedVersionsById.values();
4949
return Array.from(versions)
5050
.sort(compareVersionByDate)
5151
.map(v => v.id);
5252
}
5353

5454
/** @return {Map<number, import("../models/version").default>} */
5555
@cached
56-
get versionsObj() {
56+
get loadedVersionsById() {
5757
let versionsRef = this.hasMany('versions');
5858
let values = versionsRef.value();
5959
return new Map(values?.map(ref => [ref.id, ref]));
@@ -69,7 +69,7 @@ export default class Crate extends Model {
6969

7070
@cached get releaseTrackSet() {
7171
let map = new Map();
72-
let { versionsObj: versions, versionIdsBySemver } = this;
72+
let { loadedVersionsById: versions, versionIdsBySemver } = this;
7373
for (let id of versionIdsBySemver) {
7474
let { releaseTrack, isPrerelease, yanked } = versions.get(id);
7575
if (releaseTrack && !isPrerelease && !yanked && !map.has(releaseTrack)) {

0 commit comments

Comments
 (0)