views: Remove badges arguments from EncodableCrate constructors

There are either set to `None` or `Some(vec![])` these days, but we might as well initialize them with an empty static array instead and never return `null`.

Author: Turbo87

src/controllers/krate/metadata.rs

@@ -117,8 +117,6 @@ pub async fn show(app: AppState, Path(name): Path<String>, req: Parts) -> AppRes
             None
         };
 
-        let badges = if include.badges { Some(vec![]) } else { None };
-
         let top_versions = if include.versions {
             Some(krate.top_versions(conn)?)
         } else {
@@ -132,7 +130,6 @@ pub async fn show(app: AppState, Path(name): Path<String>, req: Parts) -> AppRes
             ids,
             kws.as_deref(),
             cats.as_deref(),
-            badges,
             false,
             downloads,
             recent_downloads,

src/controllers/krate/publish.rs

@@ -512,7 +512,6 @@ pub async fn publish(app: AppState, req: BytesRequest) -> AppResult<Json<GoodCra
                     krate,
                     default_version.or(Some(version_string)).as_deref(),
                     Some(&top_versions),
-                    None,
                     false,
                     downloads,
                     None,

src/controllers/krate/search.rs

@@ -236,7 +236,6 @@ pub async fn search(app: AppState, req: Parts) -> AppResult<Json<Value>> {
                         krate,
                         default_version.as_deref(),
                         Some(&max_version),
-                        Some(vec![]),
                         perfect_match,
                         total,
                         Some(recent.unwrap_or(0)),

src/controllers/summary.rs

@@ -41,7 +41,6 @@ pub async fn summary(state: AppState) -> AppResult<Json<Value>> {
                         krate,
                         default_version.as_deref(),
                         Some(&top_versions),
-                        None,
                         false,
                         total,
                         recent,

src/tests/krate/publish/snapshots/crates_io__tests__krate__publish__basics__new_krate.snap

@@ -4,7 +4,7 @@ expression: response.json()
 ---
 {
   "crate": {
-    "badges": null,
+    "badges": [],
     "categories": null,
     "created_at": "[datetime]",
     "default_version": "1.0.0",

src/tests/krate/publish/snapshots/crates_io__tests__krate__publish__basics__new_krate_twice.snap

@@ -4,7 +4,7 @@ expression: response.json()
 ---
 {
   "crate": {
-    "badges": null,
+    "badges": [],
     "categories": null,
     "created_at": "[datetime]",
     "default_version": "2.0.0",

src/tests/krate/publish/snapshots/crates_io__tests__krate__publish__basics__new_krate_twice_alt.snap

@@ -4,7 +4,7 @@ expression: response.json()
 ---
 {
   "crate": {
-    "badges": null,
+    "badges": [],
     "categories": null,
     "created_at": "[datetime]",
     "default_version": "2.0.0",

src/tests/krate/publish/snapshots/crates_io__tests__krate__publish__basics__new_krate_weird_version.snap

@@ -4,7 +4,7 @@ expression: response.json()
 ---
 {
   "crate": {
-    "badges": null,
+    "badges": [],
     "categories": null,
     "created_at": "[datetime]",
     "default_version": "0.0.0-pre",

src/tests/krate/publish/snapshots/crates_io__tests__krate__publish__basics__new_krate_with_token.snap

@@ -4,7 +4,7 @@ expression: response.json()
 ---
 {
   "crate": {
-    "badges": null,
+    "badges": [],
     "categories": null,
     "created_at": "[datetime]",
     "default_version": "1.0.0",

src/tests/krate/publish/snapshots/crates_io__tests__krate__publish__build_metadata__version_with_build_metadata@build_metadata_1.snap

@@ -4,7 +4,7 @@ expression: response.json()
 ---
 {
   "crate": {
-    "badges": null,
+    "badges": [],
     "categories": null,
     "created_at": "[datetime]",
     "default_version": "1.0.0+foo",